Skip to content

Allow choice to edit using VisualEditor or Source editor. - #6756

Merged
cooltey merged 84 commits into
mainfrom
veDialog_design
Aug 19, 2026
Merged

cooltey merged 84 commits into
mainfrom
veDialog_design

Conversation

@dbrant

@dbrant dbrant commented Jul 27, 2026

Copy link
Copy Markdown
Member

@voyagerfan

Copy link
Copy Markdown
Collaborator

@cooltey I've the feature branch and it looks good.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

Suppressed comments (2)

app/src/main/java/org/wikipedia/page/PageActivity.kt:535

  • This branch cannot observe normal app-icon launches: both launcher aliases target MainActivity (AndroidManifest.xml:96,107), while this PR removed the corresponding handling there. As a result, apps-open no longer emits actionSource = "app_icon". Keep this event handling in MainActivity (or route launcher intents here).
        if (intent.action == Intent.ACTION_MAIN && intent.categories?.contains(Intent.CATEGORY_LAUNCHER) == true) {
            TestKitchenAdapter.client.getInstrument("apps-open")
                .submitInteraction(action = "app_open", actionSource = "app_icon")

app/src/main/java/org/wikipedia/page/PageActivity.kt:557

  • After handling a wikipedia:// return, execution falls through to line 641 and opens the callback URI with NEW_TAB_FOREGROUND. Because this single-task activity normally receives the browser return through onNewIntent while the edited tab is still active, both saved and abandoned callbacks create a duplicate tab, and the saved refresh can race that new load. Return after handling an existing-page callback, and only load the URI when restoring from a cold start.
            if (uri.scheme == "wikipedia") {
                uri = uri.buildUpon().scheme(WikiSite.DEFAULT_SCHEME).build()
                uri.getQueryParameter("saved")?.let {
                    if (it == "true") {

@cooltey
cooltey merged commit d099fe4 into main Aug 19, 2026
2 checks passed
@cooltey
cooltey deleted the veDialog_design branch August 19, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in progress

Development

Successfully merging this pull request may close these issues.

5 participants