Remove the Wikipedia games announcement popup and its toast - #6761
Open
Zaidusyy wants to merge 4 commits into
Open
Remove the Wikipedia games announcement popup and its toast#6761Zaidusyy wants to merge 4 commits into
Zaidusyy wants to merge 4 commits into
Conversation
Zaidusyy
requested review from
Williamrai,
cooltey,
dbrant and
voyagerfan
as code owners
July 29, 2026 22:02
The games have been available for a while, so the onboarding popup and its accompanying toast are no longer needed. Removes the dialog, its layout, the unused preference and strings, and the call site in PageFragment. Bug: T432769 Change-Id: I1cdbe4967dbacea53734dca0b9960046fb16da89
Zaidusyy
force-pushed
the
remove-games-announcement-popup
branch
from
July 29, 2026 22:32
3a3e777 to
18ef49d
Compare
Collaborator
|
Hi @Zaidusyy Thank you for the PR. It should be okay to remove the home-feed tooltip in this PR. you can simply remove the isHomeFeedUpdateTooltipShown preference check, and the survey should continue to work. |
Per review: removes the isHomeFeedUpdateTooltipShown check, the tooltip itself, and its now-unused preference. The home feed survey no longer depends on the tooltip having been shown. Bug: T432769
Author
|
Thanks @Williamrai done. Removed the tooltip, the isHomeFeedUpdateTooltipShown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wikipedia games have been around for a while now, so the "Introducing
Wikipedia games" popup and the toast that shows after you close it aren't really
needed anymore. This removes the dialog and its layout, the call in PageFragment,
and the pref/strings that only that popup used.
I kept this to just the games popup for now - the home-feed tooltip listed under
"nice to have" touches some survey logic, so I left it out and it can be a
separate follow-up if wanted.
Ran compileDevDebugKotlin and :app:ktlint locally, both pass.
Bug: T432769