[Reading Lists] New bottom sheet dialog to save unsave by Williamrai · Pull Request #6771 · wikimedia/apps-android-wikipedia

Williamrai · 2026-08-05T14:33:38Z

What does this do?

adds new SaveArticleSheetDialog to save and unsave articles to collections and default list
Adds autoHidingLazyColumnScrollbar Modifier
removes "Add/Move/Remove" from LongPressMenu

Phabricator:
https://phabricator.wikimedia.org/T430375

…paring with old XML version. Will be removed once migration is complete. - creates ReadingListsComposeFragment, creates a compose screen, wires searchActionMode and overflowMenu, adds TODO's

- Add a one-to-many Room relation between ReadingList and ReadingListPage. - implements DAO functions returning Flow to reactively observe reading list data - adds ReadingListsUiState an ui state for the screen and ReadingListRow for handling list row and page row UI - implements in-memory filtering for complex queries that cannot be evaluated directly by ROOM

…iew for ReadingListsFragment)

…w for ReadingListsFragment)

- update MessageCard compose UI to match XML MessageCard - updates ReadingListsViewModel.kt to support new onboarding state - restructure ReadingListsComposeScreen.kt to support onboarding state - adds searchActive flow to detect search action mode in order to hide onboarding state

…e' into reading-list-migration-to-compose

- adds multi selection mode - adds overflow menu callback actions - adds multiSelection callback actions - updates UI to support multi selection mode and pull to refresh action - code fixes

… for efficiency

- adds Dropdown menu actions - adds two queries to simplifying and efficiently retrieving reading list with pages - adds helper function toReadingList to filter pages queued for deletion

…e' into reading-list-migration-to-compose

- improves ReadingListItemActionsDialog newInstance function by passing what it actually uses instead of lists - creates ContainingList data class to save id and title of the lists that contains the page. This is used for the added PageRow actions - code fixes and UI updates

- adds offline toggle action in ReadingListPageRow - adds logic to show snackbar message when total list reaches max limit - bug fixes: deleting list from the ReadingList detail screen did not show undo snackbar when coming back to the main list screen

… saved. Introduces RecentPreviewSavedState which holds two values one for showing snackbar and the other for badge. - updates ui and code

…out updates - subscribes LoggedInEvent, LoggedOutEvent and LoggedOutInBackgroundEvent

… getNewRecommendedPagesFlow and splits its own combine with related preferences - ui fixes: scroll to first item when discover card appears

…e' into reading-list-migration-to-compose

- updates the viewModel logic to support this separation

…cEvent is emitted when sync is completed to dismiss the refresh spinner

- code updates to support the new search behavior

…l articles

…perience # Conflicts: # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml

… adds lifecycle aware flow collection of ArticleSavedOrDeletedEvent to update save button whenever user adds or removes the article - adds codes to derive decision to save only when it's not saved

…oved and displays a snackbar message, except when the article is removed from its only saved list (the default list)

…r "Saved" for overflow menu callbacks and long press menu callbak and replace it with a single request

…perience # Conflicts: # app/src/main/res/values-qq/strings.xml

- removes move and add from ReadingListItemActionsDialog - adds string resources - code fixes

- thumb height is now proportional to fraction of the lazy column content and uses the native scrollIndicatorState

…experience # Conflicts: # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml

Copilot

Pull request overview

Introduces a unified bottom sheet for saving articles and managing collection membership across the app.

Changes:

Adds the Compose save/unsave sheet and supporting ViewModel.
Replaces legacy save, move, and remove flows across article surfaces.
Updates reading-list actions, resources, and scrollbar behavior.

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`app/src/main/res/values/strings.xml`	Adds sheet text and collection counts.
`app/src/main/res/values/dimens.xml`	Adds sheet peek height.
`app/src/main/res/values-qq/strings.xml`	Adds localization descriptions.
`app/src/main/res/menu/menu_reading_list_page_toggle.xml`	Removes obsolete menu.
`app/src/main/res/menu/menu_places_long_press.xml`	Removes legacy collection actions.
`app/src/main/res/menu/menu_long_press.xml`	Removes legacy collection actions.
`app/src/main/res/layout/view_reading_list_page_actions.xml`	Consolidates collection management action.
`app/src/main/res/drawable/ic_add_circle_24dp.xml`	Adds collection-add icon.
`app/src/main/java/org/wikipedia/search/SearchResultLongPressHandler.kt`	Routes search saves to the sheet.
`app/src/main/java/org/wikipedia/search/SearchResultCallback.kt`	Simplifies the save callback.
`app/src/main/java/org/wikipedia/search/SearchFragment.kt`	Opens the sheet from search.
`app/src/main/java/org/wikipedia/readinglist/SaveArticleSheetViewModel.kt`	Implements save and collection operations.
`app/src/main/java/org/wikipedia/readinglist/SaveArticleSheetDialog.kt`	Hosts the new bottom sheet.
`app/src/main/java/org/wikipedia/readinglist/ReadingListsViewModel.kt`	Tracks default-list membership.
`app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.kt`	Opens collection management.
`app/src/main/java/org/wikipedia/readinglist/ReadingListItemActionsView.kt`	Consolidates item actions.
`app/src/main/java/org/wikipedia/readinglist/ReadingListItemActionsDialog.kt`	Displays collection membership action.
`app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.kt`	Integrates the new sheet.
`app/src/main/java/org/wikipedia/readinglist/LongPressMenu.kt`	Unifies long-press save behavior.
`app/src/main/java/org/wikipedia/readinglist/compose/SaveArticleSheetContent.kt`	Defines the Compose sheet UI.
`app/src/main/java/org/wikipedia/random/RandomActivity.kt`	Uses the sheet for random articles.
`app/src/main/java/org/wikipedia/places/PlacesFragment.kt`	Uses the sheet from Places.
`app/src/main/java/org/wikipedia/page/PageFragment.kt`	Uses the sheet from article actions.
`app/src/main/java/org/wikipedia/page/PageContainerLongPressHandler.kt`	Uses the sheet for links.
`app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.kt`	Uses the sheet from previews.
`app/src/main/java/org/wikipedia/main/MainFragment.kt`	Routes feed save requests.
`app/src/main/java/org/wikipedia/games/onthisday/OnThisDayGameViewModel.kt`	Removes duplicated saved-page state.
`app/src/main/java/org/wikipedia/games/onthisday/OnThisDayGameResultFragment.kt`	Uses the sheet in game results.
`app/src/main/java/org/wikipedia/games/onthisday/OnThisDayGameArticleBottomSheet.kt`	Uses database-backed save state.
`app/src/main/java/org/wikipedia/feed/view/ListItemView.kt`	Simplifies feed save callbacks.
`app/src/main/java/org/wikipedia/feed/topread/TopReadFragment.kt`	Opens the sheet from top reads.
`app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayPagesViewHolder.kt`	Opens the sheet from events.
`app/src/main/java/org/wikipedia/feed/news/NewsFragment.kt`	Opens the sheet from news.
`app/src/main/java/org/wikipedia/feed/HomeFragment.kt`	Replaces direct feed save handling.
`app/src/main/java/org/wikipedia/feed/ForYouCard.kt`	Updates saved menu labeling.
`app/src/main/java/org/wikipedia/feed/didyouknow/DidYouKnowActivity.kt`	Opens the sheet from Did You Know.
`app/src/main/java/org/wikipedia/compose/extensions/Modifier.kt`	Adds an auto-hiding scrollbar.
`app/src/main/java/org/wikipedia/compose/components/menu/PageOverflowMenuViewModel.kt`	Unifies overflow save actions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

dbrant · 2026-08-13T18:04:50Z

+        } catch (exception: IOException) {
+            // A network error (or being offline) during the redirect resolution is not a big deal,
+            // and we can just proceed with the original title.
+            L.e(exception)
+            null
+        }


Kind of agree.

- code/ui fixes - add code-review skill for testing (experiment)

Copilot

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

Williamrai · 2026-08-13T18:49:08Z

+        )
+
+    private fun saveArticle() {
+        viewModelScope.launch(exceptionHandler) {


based on product leaving this as is, and see if we get user reports.

Williamrai · 2026-08-13T18:49:12Z

+
+    val pageTitle = savedStateHandle.get<PageTitle>(Constants.ARG_TITLE)!!
+
+    private val savedPageTitle = MutableStateFlow(pageTitle)


based on product leaving this as is, and see if we get user reports.

…experience

Williamrai and others added 30 commits July 8, 2026 16:05

- repurpose activity tab to use reading lists compose version for com…

fefd3e6

…paring with old XML version. Will be removed once migration is complete. - creates ReadingListsComposeFragment, creates a compose screen, wires searchActionMode and overflowMenu, adds TODO's

- adds ReadingListRow (which is a jetpack version of ReadingListItemV…

1847bb7

…iew for ReadingListsFragment)

- adds ReadingListPageRow.kt (which is jetpack version of PageItemVie…

caf0c53

…w for ReadingListsFragment)

- adds empty state

d04a33b

Merge branch 'main' into reading-list-migration-to-compose

bd7f214

Merge remote-tracking branch 'origin/reading-list-migration-to-compos…

d085e81

…e' into reading-list-migration-to-compose

- adds pull to refresh

b0a2060

- adds multi selection mode - adds overflow menu callback actions - adds multiSelection callback actions - updates UI to support multi selection mode and pull to refresh action - code fixes

- removes selection state from UiState and make it a standalone state…

fe60a33

… for efficiency

Merge branch 'main' into reading-list-migration-to-compose

728c0ba

- adds Dropdown menu for long click on ListRow

5cc0f6c

- adds Dropdown menu actions - adds two queries to simplifying and efficiently retrieving reading list with pages - adds helper function toReadingList to filter pages queued for deletion

Merge remote-tracking branch 'origin/reading-list-migration-to-compos…

ed9977f

…e' into reading-list-migration-to-compose

- adds support for showing snackbar and new badge when shared list is…

93f815e

… saved. Introduces RecentPreviewSavedState which holds two values one for showing snackbar and the other for badge. - updates ui and code

- adds ReadingListsAccountState data class to simplify the login/log …

c3a9aef

…out updates - subscribes LoggedInEvent, LoggedOutEvent and LoggedOutInBackgroundEvent

- adds page download progress

7f8bd9f

- code cleanups

85afbd9

Merge branch 'main' into reading-list-migration-to-compose

58128a4

- rename reading list fragment and compose screen

dca99e2

- improve search algorithm and adds a debounce

c21d5ef

Merge branch 'main' into reading-list-migration-to-compose

e5c1701

- migrates the discover card source of truth to DB query flow through…

ea5ee8e

… getNewRecommendedPagesFlow and splits its own combine with related preferences - ui fixes: scroll to first item when discover card appears

Merge remote-tracking branch 'origin/reading-list-migration-to-compos…

6c69dba

…e' into reading-list-migration-to-compose

- adds loading state

bf4cd41

- splits the ReadingListsScreen into All articles and Collections tab

3751c61

- updates the viewModel logic to support this separation

- adds the REFRESHING flag to manualSyncWithForce() so ReadingListSyn…

607c4f5

…cEvent is emitted when sync is completed to dismiss the refresh spinner

- separates the search mode (searches the active tab)

b8d0a5f

- code updates to support the new search behavior

- show recommended onboarding only on collections and other two on al…

91691fb

…l articles

Williamrai requested review from cooltey, dbrant and voyagerfan as code owners August 5, 2026 14:33

Williamrai and others added 11 commits August 5, 2026 10:35

Merge remote-tracking branch 'origin/main' into rl-new-save-unsave-ex…

a4bf1c7

…perience # Conflicts: # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml

- replaces AddToReadingListDialog with SaveArticleSheetDialog

d47c2ce

Merge branch 'main' into rl-new-save-unsave-experience

4227925

- adjusts code to fit new changes in OnThisDayGameArticleBottomSheet.…

4f6319b

… adds lifecycle aware flow collection of ArticleSavedOrDeletedEvent to update save button whenever user adds or removes the article - adds codes to derive decision to save only when it's not saved

- save Article bottom sheet now auto-dismisses when an article is rem…

0f928c6

…oved and displays a snackbar message, except when the article is removed from its only saved list (the default list)

- removes add to another list, remove and move and only keep "Save" o…

f3236b3

…r "Saved" for overflow menu callbacks and long press menu callbak and replace it with a single request

Merge remote-tracking branch 'origin/main' into rl-new-save-unsave-ex…

faf41f3

…perience # Conflicts: # app/src/main/res/values-qq/strings.xml

Merge branch 'main' into rl-new-save-unsave-experience

586ef37

Merge branch 'main' into rl-new-save-unsave-experience

5413b07

- adds a Modifier autoHidingLazyColumnScrollbar

6488178

- removes move and add from ReadingListItemActionsDialog - adds string resources - code fixes

Merge branch 'main' into rl-new-save-unsave-experience

13f999e

Williamrai changed the base branch from main to rl-collections-feature-branch August 11, 2026 15:42

Williamrai added 2 commits August 11, 2026 16:00

- fixes scrollbar visibility

8428f59

- thumb height is now proportional to fraction of the lazy column content and uses the native scrollIndicatorState

Merge branch 'rl-collections-feature-branch' into rl-new-save-unsave-…

f475006

…experience # Conflicts: # app/src/main/res/values-qq/strings.xml # app/src/main/res/values/strings.xml

Williamrai added Ready for Review and removed WIP Work in progress labels Aug 12, 2026

Williamrai requested a balanced review from Copilot August 12, 2026 14:10

Copilot started reviewing on behalf of Williamrai August 12, 2026 14:17 View session

Copilot AI reviewed Aug 12, 2026

View reviewed changes

- adds accessibility

17237db

- code/ui fixes - add code-review skill for testing (experiment)

Williamrai requested a balanced review from Copilot August 12, 2026 19:20

Copilot started reviewing on behalf of Williamrai August 12, 2026 19:21 View session

Copilot AI reviewed Aug 12, 2026

View reviewed changes

Williamrai and others added 2 commits August 13, 2026 13:23

- removes the code-review skill

80b9cf4

Merge branch 'rl-collections-feature-branch' into rl-new-save-unsave-…

9ddf40d

…experience

dbrant merged commit 57c2353 into rl-collections-feature-branch Aug 13, 2026
1 check passed

dbrant deleted the rl-new-save-unsave-experience branch August 13, 2026 19:30

Navigation Menu

Uh oh!

Uh oh!

[Reading Lists] New bottom sheet dialog to save unsave - #6771

[Reading Lists] New bottom sheet dialog to save unsave#6771
dbrant merged 78 commits into
rl-collections-feature-branchfrom
rl-new-save-unsave-experience

Williamrai commented Aug 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

dbrant Aug 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Williamrai Aug 13, 2026 •

edited

Loading

Uh oh!

Williamrai Aug 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants


		val pageTitle = savedStateHandle.get<PageTitle>(Constants.ARG_TITLE)!!

		private val savedPageTitle = MutableStateFlow(pageTitle)

Uh oh!

Uh oh!

Conversation

Williamrai commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this do?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

dbrant Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Williamrai Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Williamrai Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Williamrai commented Aug 5, 2026 •

edited

Loading

Williamrai Aug 13, 2026 •

edited

Loading

Williamrai Aug 13, 2026 •

edited

Loading