Skip to content

Adding action=abort events to editattemptstep for certain edit actions - #6774

Merged
dbrant merged 14 commits into
mainfrom
editattemptstep-abort
Aug 13, 2026
Merged

Adding action=abort events to editattemptstep for certain edit actions#6774
dbrant merged 14 commits into
mainfrom
editattemptstep-abort

Conversation

@cooltey

@cooltey cooltey commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

What does this do?

  1. Adds abort action to EditAttemptStepEvent
  2. Sends EditAttemptStepEvent.logAbort(title) when dismiss PopupMenu manually.
  3. Replaces logSaveFailure with logAbort in EditSectionActivity as requested.

Phabricator:
https://phabricator.wikimedia.org/T433909

@cooltey cooltey added the Ready to merge PR passed design signoff and ready to be merged. label Aug 6, 2026

@voyagerfan voyagerfan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question on logAbort placement

Comment thread app/src/main/java/org/wikipedia/edit/EditSectionActivity.kt Outdated
@dbrant
dbrant merged commit be95370 into main Aug 13, 2026
1 check passed
@dbrant
dbrant deleted the editattemptstep-abort branch August 13, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge PR passed design signoff and ready to be merged.

Development

Successfully merging this pull request may close these issues.

4 participants