fix: check for static link of dynamic object#1886
Merged
Merged
Conversation
Member
davidlattimore
left a comment
davidlattimore
left a comment
There was a problem hiding this comment.
Thanks for this. Always good to see improvements to our error reporting.
TechnoPorg
force-pushed
the
push-uxoyppvwkssw
branch
2 times, most recently
from
05a179e to
d3031ab
Compare
davidlattimore
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allow_shared modifier currently only applies if given a library name as an input, but is ignored if given a filename. This PR adds a check to see whether a shared object given as a filename is allowed to be linked.
Split off from #1884.