Speed up import ~9x by using one shared Lark parser#11
Open
agentydragon wants to merge 1 commit into
Open
Conversation
Previously, make_syntax_validator() created a new Lark parser for each rule, which was expensive (~660ms total import time). This change: - Defines ALL_START_RULES containing all grammar rules needed by validators - Creates a single shared syntax_parser with all start rules upfront - Refactors make_syntax_validator() to use functools.partial with is_valid_syntax() instead of creating new parsers Import time reduced from ~660ms to ~72ms (9x speedup). Testing protocol: - Created timing script that clears module cache and measures import time - Ran 5 iterations for each version to account for variance - Used git stash to preserve dirty state while testing HEAD - Results: HEAD averaged ~662ms, this change averages ~72ms - All existing tests pass (2/2)
There was a problem hiding this comment.
Pull request overview
This PR optimizes import time by ~9x (from ~660ms to ~72ms) by creating a single shared Lark parser instead of instantiating a new parser for each validation rule.
Key Changes:
- Introduced
ALL_START_RULEScontaining all 38 grammar rules needed by validators - Modified
syntax_parserto be instantiated once with all start rules upfront - Refactored
make_syntax_validator()to usefunctools.partialwith the shared parser instead of creating individual parsers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agentydragon
changed the title
ryanbordo
approved these changes
Jan 6, 2026
This was referenced Jan 6, 2026
Author
|
@willynilly hi! do you think we could merge this? or would you like me to do any changes / testing? |
|
Shouldn't these changes be merged? Are there any maintainers active here? |
26 tasks
Collaborator
see #15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, make_syntax_validator() created a new Lark parser for each rule, which was expensive (~660ms total import time). This change:
Import time reduced from ~660ms to ~72ms (9x speedup).
Also fixed a forgotten comma that previously caused implicit string literal concatenation: