Conversation
|
|
| Branch | docs/mls |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 940.88 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 351,493.01 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,250,000.24 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 20,593.81 µs |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3974 +/- ##
===========================================
+ Coverage 59.92% 59.93% +0.01%
===========================================
Files 1981 1982 +1
Lines 64084 64108 +24
Branches 6994 6996 +2
===========================================
+ Hits 38400 38425 +25
Misses 22540 22540
+ Partials 3144 3143 -1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
||
| ## Cross-Platform Review Questions | ||
|
|
||
| These are the most useful questions for other client teams / core-crypto reviewers: |
There was a problem hiding this comment.
May be worth looking into for resilience against duplicate event processing: https://wireapp.github.io/core-crypto/v9.3.1/kotlin/-core-crypto/com.wire.crypto/-core-crypto-context-interface/set-data.htm it allows an ID or anything other string to be stored in core crypto together when a transaction commits
| 4. Should `setEventsAsProcessed(...)` eventually move inside the same durable unit as side effects, or is Android's current split acceptable? | ||
| 5. Which MLS/core-crypto failures are safe to treat as duplicate/no-op vs requiring rejoin/reset? | ||
|
|
||
| ## Current Android Position |
There was a problem hiding this comment.
Maybe you should also add to move side effects out of the event processing. For example if you need refresh a conversation metadata due to an event, do mark that it needs it needs to be done but the actual work outside the event processing.
Doing work like this inside event processing causes long lived CC transaction which is bad for event processing throughput.
It might also reduce the impact of processing an event twice.
|
There's some duplication going on across: |



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
Issues
Causes (Optional)
Solutions
docs/mls/.MLSWelcome,NewMLSMessage, andMLSReset.