Skip to content

feat: add use case for migrating a single conversation to MLS [WPB-8645]#4103

Open
typfel wants to merge 1 commit into
developfrom
jacob/feat/migrate-conversation
Open

feat: add use case for migrating a single conversation to MLS [WPB-8645]#4103
typfel wants to merge 1 commit into
developfrom
jacob/feat/migrate-conversation

Conversation

@typfel
Copy link
Copy Markdown
Member

@typfel typfel commented May 4, 2026

https://wearezeta.atlassian.net/browse/WPB-8645


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add a use case for migrating a single conversation to MLS.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test Results

0 tests   - 4 890   0 ✅  - 4 775   0s ⏱️ - 2m 44s
0 suites  -   803   0 💤  -   115 
0 files    -   803   0 ❌ ±    0 

Results for commit 5ebc8cd. ± Comparison against base commit de33718.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🐰 Bencher Report

Branchjacob/feat/migrate-conversation
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
726.11 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
419,807.92 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
104,022.46 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
99,986.54 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.localMarkAsReadBenchmark📈 view plot
⚠️ NO THRESHOLD
2,974.92 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
23,646.84 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
11,113.54 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,243,146.68 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
23,610.41 µs
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 5, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.61%. Comparing base (de33718) to head (5ebc8cd).

Files with missing lines Patch % Lines
...e/kalium/logic/feature/mlsmigration/MLSMigrator.kt 66.66% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #4103      +/-   ##
=============================================
+ Coverage      61.60%   61.61%   +0.01%     
  Complexity      4023     4023              
=============================================
  Files           2057     2058       +1     
  Lines          67321    67344      +23     
  Branches        6635     6637       +2     
=============================================
+ Hits           41475    41497      +22     
- Misses         23202    23203       +1     
  Partials        2644     2644              
Files with missing lines Coverage Δ
...re/conversation/MigrateConversationToMLSUseCase.kt 100.00% <100.00%> (ø)
...e/kalium/logic/feature/mlsmigration/MLSMigrator.kt 79.77% <66.66%> (-0.46%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de33718...5ebc8cd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@typfel typfel changed the title feat: add use case for migrating a single conversation to MLS feat: add use case for migrating a single conversation to MLS [WPB-8645] May 5, 2026
@typfel typfel force-pushed the jacob/feat/migrate-conversation branch from e0b2c21 to 5ebc8cd Compare May 12, 2026 13:33
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants