Skip to content

feat: check admin leave conditions (WPB-25277)#4131

Merged
sbakhtiarov merged 1 commit into
developfrom
feat/check-leave-conditions
May 13, 2026
Merged

feat: check admin leave conditions (WPB-25277)#4131
sbakhtiarov merged 1 commit into
developfrom
feat/check-leave-conditions

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented May 12, 2026

https://wearezeta.atlassian.net/browse/WPB-25277

https://wearezeta.atlassian.net/browse/WPB-25277

What's new in this PR?

New use-cases for Admin-less groups handling feature.

  • Check conditions for allowing or not allowing user admin to leave conversation
  • Return a list of conversation members eligible for admin role promotion

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Test Results

0 tests   - 4 890   0 ✅  - 4 775   0s ⏱️ - 2m 44s
0 suites  -   803   0 💤  -   115 
0 files    -   803   0 ❌ ±    0 

Results for commit 32d070e. ± Comparison against base commit de33718.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2026

Codecov Report

❌ Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.61%. Comparing base (de33718) to head (32d070e).

Files with missing lines Patch % Lines
...um/logic/feature/conversation/ConversationScope.kt 0.00% 5 Missing ⚠️
...rsation/CheckConversationLeaveConditionsUseCase.kt 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #4131      +/-   ##
=============================================
+ Coverage      61.60%   61.61%   +0.01%     
  Complexity      4023     4023              
=============================================
  Files           2057     2059       +2     
  Lines          67321    67355      +34     
  Branches        6635     6649      +14     
=============================================
+ Hits           41475    41503      +28     
- Misses         23202    23206       +4     
- Partials        2644     2646       +2     
Files with missing lines Coverage Δ
...eEligibleMembersForConversationAdminRoleUseCase.kt 100.00% <100.00%> (ø)
...rsation/CheckConversationLeaveConditionsUseCase.kt 88.88% <88.88%> (ø)
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de33718...32d070e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

🐰 Bencher Report

Branchfeat/check-leave-conditions
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
716.72 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
512,966.91 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
103,045.47 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
99,336.44 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.localMarkAsReadBenchmark📈 view plot
⚠️ NO THRESHOLD
3,007.86 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
22,589.82 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
10,460.18 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,238,598.44 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
23,239.07 µs
🐰 View full continuous benchmarking report in Bencher

@sbakhtiarov sbakhtiarov force-pushed the feat/check-leave-conditions branch from f69a608 to c7bc365 Compare May 12, 2026 13:57
@sbakhtiarov sbakhtiarov force-pushed the feat/check-leave-conditions branch 2 times, most recently from 17452a9 to fee83f3 Compare May 13, 2026 06:56
@sbakhtiarov sbakhtiarov force-pushed the feat/check-leave-conditions branch from fee83f3 to 32d070e Compare May 13, 2026 07:28
@sonarqubecloud
Copy link
Copy Markdown

@sbakhtiarov sbakhtiarov added this pull request to the merge queue May 13, 2026
Merged via the queue into develop with commit 7192839 May 13, 2026
25 checks passed
@sbakhtiarov sbakhtiarov deleted the feat/check-leave-conditions branch May 13, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants