fix: set and observe stale open calls cleanup [WPB-24829]#4134
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4134 +/- ##
==========================================
Coverage 61.61% 61.62%
- Complexity 4023 4024 +1
==========================================
Files 2059 2060 +1
Lines 67355 67368 +13
Branches 6649 6650 +1
==========================================
+ Hits 41504 41515 +11
- Misses 23206 23207 +1
- Partials 2645 2646 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…e-stale-open-calls-cleanup
|
woudn't a nice solution to not get the ongoing state from sqlite and relay purly on AVS + in memory store for it we can still store data about the calls and who called but just not if it is ongoing? |
…e-stale-open-calls-cleanup
|



https://wearezeta.atlassian.net/browse/WPB-24829
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Some actions, like starting a foreground service, are being executed for stale open calls before these calls are cleaned-up and closed.
Causes (Optional)
The clean-up is running in parallel with other actions that observe active calls so it's possible for these actions to receive outdated calls first.
Solutions
Create use case to observe the completion of this clean-up to execute other actions and start observing calls only after it's completed.
Testing
Test Coverage (Optional)
How to Test
Start/join a call, kill the app, open again - the call service shouldn't even attempt to start as the last call should be closed first when reopening the app.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.