fix: opening an archived conversation unarchives it - WPB-3772

[johnxnguyen]

WPB-3772 [iOS] Opening an archived conversation unarchives it

Issue

Navigating to the archive list and opening an archived conversation will show the conversation (expected) and also unarchive it (not expected).

For some reason there is an explicit call to unarchive the conversation, the fix is to remove this call.

Testing

1. Archive a conversation
2. Go to archive, see the conversation, open it
3. See the conversation content, go back
4. Assert the conversation is still in the archive.

---

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

---

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Make sure you use the API for UI elements that support large fonts.
• All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
• New UI elements have Accessibility strings for VoiceOver.

[github-actions]

Test Results

 1 files   6 suites   5m 24s ⏱️
13 tests  9 ✅ 0 💤 4 ❌
13 runs  10 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 6fe974d.

♻️ This comment has been updated with latest results.