-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
i18n(de): tutorial #12502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(de): tutorial #12502
Conversation
* Create index in German.mdx * Apply suggestions from code review Co-authored-by: Because789 <[email protected]> * fix description --------- Co-authored-by: Because789 <[email protected]> Co-authored-by: Yan <[email protected]>
* i18n(de): add 1-setup to german blog tutorial Adding German translation to Blog tutorial. * Apply suggestions from code review Implement feedback from review. Co-authored-by: Because789 <[email protected]> * Fehlermeldung im Original Korrektur nach Feedback. * Update src/content/docs/de/tutorial/1-setup/1.mdx Co-authored-by: Because789 <[email protected]> --------- Co-authored-by: Because789 <[email protected]> Co-authored-by: Yan <[email protected]>
* add `3-components/index` * Update index.mdx
* add `3-components/1` * fixing typos round 1 * Update src/content/docs/de/tutorial/3-components/1.mdx Co-authored-by: Timon Jurschitsch <[email protected]> --------- Co-authored-by: Timon Jurschitsch <[email protected]> Co-authored-by: Yan <[email protected]>
Co-authored-by: Max <[email protected]>
* add translation * first batch of typos * Update src/content/docs/de/tutorial/3-components/3.mdx Co-authored-by: Timon Jurschitsch <[email protected]> --------- Co-authored-by: Timon Jurschitsch <[email protected]>
* add `3-components/2.mdx` * fix first batch of typos --------- Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]>
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve reviewed this PR and changed some formatting so it is more consistent with other tutorial‐related PRs being translated to German.
But what I’ve noticed is that there’s lots of inconsistency on which term to use. Maybe once all tutorial pages are done being translated, they should all be reviewed so it uses a consistent writing style.
This comment was marked as duplicate.
This comment was marked as duplicate.
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed something again to replace the “incorrect” quotes with the „correct ones“.
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just consistency fixes. ✨
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: Felix Schneider <[email protected]> Co-authored-by: Louis Escher <[email protected]> Co-authored-by: Yan <[email protected]>
Co-authored-by: Yan <[email protected]> Co-authored-by: Felix Schneider <[email protected]> Co-authored-by: Louis Escher <[email protected]>
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This took absolutely forever to review, but these are hopefully the final consistency comments for the tutorial.
| <MultipleChoice> | ||
| <Option>params</Option> | ||
| <Option>dynamic routing</Option> | ||
| <Option isCorrect>`getStaticPaths()`</Option> | ||
| <Option>props</Option> | ||
| </MultipleChoice> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might just be me, but I’m not sure why these aren’t translated.
I have noticed this long ago, but never pointed it out, so might as well do it now.
They also have to be translated for the other questions if you decide to translate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment for you to chime in on @trueberryless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, gonna do that in a PR!
| --- | ||
| type: tutorial | ||
| unitTitle: Erstelle und gestalte mit Astro-Komponenten | ||
| title: 'Check-in: Lektion 3 – Komponenten' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: 'Check-in: Lektion 3 – Komponenten' | |
| title: 'Wissenscheck: Lektion 3 – Komponenten' |
Not sure if we should translate this… but if we should, I have a few suggestions:
- Wissenscheck
- Selbstcheck
- Lernkontrolle
- Kontrolle
- Überprüfung
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like "Wissenscheck"! @trueberryless thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, Wissenscheck is even better, I might PR all changes...
Co-authored-by: randomguy-2650 <[email protected]>
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important consistency changes left for the tutorial, then let it sail on its raft to the Astro islands! 🏝️
|
|
||
| - [Mehr über Astro-Komponenten](/de/basics/astro-components/) | ||
|
|
||
| - [Refactoring](https://refactoring.com/) <Badge class="neutral-badge" text="extern" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [Refactoring](https://refactoring.com/) <Badge class="neutral-badge" text="extern" /> | |
| - [Refactoring](https://refactoring.com/) <Badge class="neutral-badge" text="external" /> |
All other badges stay in English, what should we use?
I haven’t seen all badges yet, but we should decide on one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich hätte Badges eigentlich auch Übersetzt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it in a follow-up PR, this thread could be resolved 👍
| - Erstelle eine Fußzeilenkomponente | ||
| - Erstelle und übergebe Props an eine Social-Media-Komponente |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Erstelle eine Fußzeilenkomponente | |
| - Erstelle und übergebe Props an eine Social-Media-Komponente | |
| - Eine Fußzeilenkomponente zu erstellen | |
| - Props an eine Social-Media-Komponente zu erstellen und übergeben |
The top part says “Mach dich bereit, …” of the PreCheck, so we should make it flow smoothly with the beginning.
You do have to find and replace all instances of this.
Reading it as “Mach dich bereit, erstelle eine Fußzeilenkomponente” sounds weird, “Mach dich bereit, eine Fußzeilenkomponente zu erstellen” sounds better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna do that in another PR as well 👍
| Herzlichen Glückwunsch zum Abschluss des Astro-Blog-Tutorials! Teile deinen Erfolg mit der Welt und lass alle wissen, dass du jetzt ein Astronaut bist! | ||
|
|
||
| <div style="display: flex; flex-wrap: wrap; gap: 0.5rem;"> | ||
| <Button link='https://twitter.com/intent/tweet?text=Ich%20habe%20gerade%20gelernt%2C%20wie%20ich%20meinen%20ersten%20Astro-Blog%20erstelle!%20Schau%20es%20dir%20an%20unter%20https://docs.astro.build/%0Avia%20%40astrodotbuild'>Auf X (Twitter) teilen</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question still is: Should be switch it to x.com? The original doesn’t use it but it’s kinda stupid because of Elon Musk’s stupid idea of thinking “X” is the best letter and therefore changing Twitter’s name to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for links we should keep to the original
|
|
||
| Die folgenden Schritte zeigen dir, wie du das Endergebnis des Blog-Tutorials erweiterst, indem du eine Content-Collection für deine Blogbeiträge erstellst. | ||
|
|
||
| ## Abhängigkeiten aktualisieren |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we translate “Update dependencies”… “Abhängigkeiten” doesn’t sound very good to me (although I translated this myself).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abhängigkeiten is the normal translation, I don't personally mind it tbh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abhängigkeiten is correct and I think it sounds nice 👍
Co-authored-by: randomguy-2650 <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: randomguy-2650 <[email protected]> Co-authored-by: Louis Escher <[email protected]> Co-authored-by: Yan <[email protected]>
|
This one should be very close to being done. Please all take a look and ensure that the last commits to the source English tutorial have been translated. |
Co-authored-by: randomguy-2650 <[email protected]> Co-authored-by: Yan <[email protected]>
trueberryless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Send it! 🫡🚀🏎️
Since we reviewed all individual sections and then made sure we are consistent + updated with recent commits, I'd say we are good to ship it and update anything we find as Yan and Lou also mentioned 🎄
Thanks for all the effort of you guys, was a nice ride! 🐎🏇🚴🎢🎡
|
Well done everyone! Thanks for coming together and getting this across the line. |
|
Actually, I never noticed the unresolved threads, let me PR the fixes quickly... |
Co-authored-by: randomguy-2650 <[email protected]> Co-authored-by: Louis Escher <[email protected]> Co-authored-by: Yan <[email protected]>
yanthomasdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hereby declare, thanks to the immeasurable work of the German crew, this tutorial translation... APPROVED AND READY TO GO!
Description (required)
Translate the whole tutorial into the German language
Related issues & labels (optional)
For a list of all remaining To-Do's, see this comment