-
Notifications
You must be signed in to change notification settings - Fork 24
Add GTG feature flag #3162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/GOOWOO-263-google-tag-gateway
Are you sure you want to change the base?
Add GTG feature flag #3162
Conversation
This commit introduces a feature toggle for Google Tag Gateway, enabling conditional rendering based on feature flags. It includes new constants, hooks, and UI updates to support this functionality.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/GOOWOO-263-google-tag-gateway #3162 +/- ##
==========================================================================
- Coverage 67.5% 66.8% -0.8%
- Complexity 0 5116 +5116
==========================================================================
Files 357 868 +511
Lines 5812 26227 +20415
Branches 1437 1444 +7
==========================================================================
+ Hits 3924 17510 +13586
- Misses 1717 8546 +6829
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…-ui-be GOOWOO-361 Feature Flag UI BE
QA Status: Need Feedback/fixes.
|
|
@ankitguptaindia That's correct. GTG scripts should not be present on the FE. @jamesmorrison @jjgrainger Can you kindly take a look please? Thanks! |
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/GOOWOO-361/hide-ui-when-gtg-feature-flag-is-disabled
Replace this with a good description of your changes & reasoning.
Screenshots:
Detailed test instructions:
enabledFeaturesinsrc/Admin/Admin.phpto be[ 'google_tag_gateway' ][]).Additional details:
Changelog entry