fix: correct character indexing for non-ASCII strings in markdown escaping#181
Open
CirnoV wants to merge 2 commits into
Open
fix: correct character indexing for non-ASCII strings in markdown escaping#181CirnoV wants to merge 2 commits into
CirnoV wants to merge 2 commits into
Conversation
Owner
|
Thanks for your patience and the PR!
Did you get such a panic? |
CirnoV
commented
Jul 22, 2025
Comment on lines
+121
to
+132
| assert_eq!( | ||
| to(&Node::Paragraph(Paragraph { | ||
| children: vec![Node::Text(Text { | ||
| value: String::from("테스트 [테스트] → [테스트]"), | ||
| position: None | ||
| })], | ||
| position: None | ||
| })) | ||
| .unwrap(), | ||
| "테스트 \\[테스트] → \\[테스트]\n", | ||
| "should support escaping of a shortcut reference in non-ascii text" | ||
| ); |
Author
There was a problem hiding this comment.
@wooorm Running this test on current main branch, it panics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes indexing issues when processing non-ASCII strings during markdown conversion.
value.chars().nth(*position)withvalue[*position..].chars().next()for proper byte-basedindexing