feat(core): add board event observer - #1163
Open
pubuzhixing8 wants to merge 1 commit into
Open
Conversation
Deploying plait with
|
| Latest commit: |
fb7e9bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d79f4613.plait.pages.dev |
| Branch Preview URL: | https://xingxing-add-board-event-obs.plait.pages.dev |
Deploying plait-docs with
|
| Latest commit: |
fb7e9bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://97afbd4c.plait-docs.pages.dev |
| Branch Preview URL: | https://xingxing-add-board-event-obs.plait-docs.pages.dev |
pubuzhixing8
marked this pull request as ready for review
August 2, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createBoardEventObserver()testing helperWhy
Drawnix plugin tests need to verify that a plugin delegates an event downstream, not only that no board state changed. Keeping the observer in core makes that assertion reusable without coupling it to Jasmine, Vitest, or Jest.
Validation
@plait/coresuccessfully with Angular package buildNo fixture-specific tests were added, per the requested scope.