fix(auths): accept float JWT exp in TokenStore._is_expired#10
Open
CV-GPhL wants to merge 1 commit into
Open
Conversation
A JWT exp is a NumericDate and is commonly decoded as a float. The previous "not isinstance(exp, int)" treated any float exp as expired, forcing a token refresh on every call. Accept both int and float; treat only a missing exp as expired. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A JWT
expis a NumericDate and is commonly decoded as afloat.TokenStore._is_expired(src/onedep_lib/auths/token.py) usednot isinstance(exp, int), so any floatexpwas treated as expired - whichforces an access-token refresh on every call.
Fix
Accept both
intandfloat, and treat only a missingexpas expired:Test
Adds cases to
tests/auths/test_token.py: a future floatexpis not expired,a past float
expis expired, and a missingexpis expired. Full suite green(146 passed).