Conversation
whamtet
commented
May 9, 2024
| '<%= renderHeader() %>', | ||
| '<%= renderTimepicker() %>', | ||
| '<%= renderCalendar() %>', | ||
| '<%= obj.renderHeader() %>', |
Author
There was a problem hiding this comment.
The templating syntax is slightly uglier now, but doesn't require with any more because it's deprecated.
whamtet
commented
May 9, 2024
| _onclick(e) { | ||
| let el = e.target | ||
|
|
||
| if (el.nodeName === 'OPTION') { |
Author
There was a problem hiding this comment.
Clicking Select on Firefox returns <option> as the target not <select>.
whamtet
commented
May 9, 2024
| '<span class="datepicker__field"><%= renderMinuteSelect() %></span>', | ||
| '<span class="datepicker__field"><%= renderPeriodSelect() %></span>', | ||
| '<span class="datepicker__label"><%= obj.label %></span>', | ||
| '<span style="display: inline-flex">', |
Author
There was a problem hiding this comment.
One extra span to fix display issue in Safari
whamtet
commented
Jun 1, 2024
| part = 'start' | ||
| } | ||
|
|
||
| const t0 = x => (x || x === 0); |
Author
There was a problem hiding this comment.
0 is falsy in js so we need to check for the 0 condition
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great work @wwilsman ,
I've fixed two bugs and refactored
tmplso that it no longer useswithwhich is deprecated. Shout out if you have any other suggestions!Matt