fix: detect REST context when using plain-permalink ?rest_route= routing#6
Open
superdav42 wants to merge 2 commits intox-wp:masterfrom
Open
fix: detect REST context when using plain-permalink ?rest_route= routing#6superdav42 wants to merge 2 commits intox-wp:masterfrom
superdav42 wants to merge 2 commits intox-wp:masterfrom
Conversation
WordPress routes REST API requests via `?rest_route=/...` when pretty permalinks are disabled (e.g. fresh wp-env installs, many CI environments). `XWP_Context::rest()` only checked REQUEST_URI for the /wp-json/ prefix, so plain-permalink REST requests were never detected as REST context. This caused all DI handlers with `context: CTX_REST` to be skipped, returning 404 for every REST endpoint. Add a secondary check for the `rest_route` query var to cover this path.
Refactor rest() method to use xwp_fetch_get_var for retrieving rest_route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress routes REST API requests via
?rest_route=/...when pretty permalinks are disabled (e.g. fresh wp-env installs, many CI environments).XWP_Context::rest()only checked REQUEST_URI for the /wp-json/ prefix, so plain-permalink REST requests were never detected as REST context. This caused all DI handlers withcontext: CTX_RESTto be skipped, returning 404 for every REST endpoint.Add a secondary check for the
rest_routequery var to cover this path.