Skip to content

fix: publish release-plz releases after updating notes - #415

Merged
robjtede merged 1 commit into
mainfrom
chore/undraft-releases
Oct 8, 2026
Merged

robjtede merged 1 commit into
mainfrom
chore/undraft-releases

Conversation

@robjtede

@robjtede robjtede commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Create release-plz releases as drafts.
  • Update release notes from the changelog, then publish the releases with --then-undraft.
  • Update the x52dev/nix flake lock input so CI has the new flag.

Validation

  • Reviewed the workflow, release-plz config, and flake.lock diff.
  • Did not run project tests; these changes only affect release configuration.

Summary by CodeRabbit

  • Chores
    • Release notes are undrafted during the release workflow, while GitHub releases are created as drafts. This changes the release process so release notes and the corresponding release have distinct draft statuses until the release is ready to be published.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 75cba60d-de7a-4d26-837c-91e83f868621
📥 Commits

Reviewing files that changed from the base of the PR and between ea0b26e and 3307a70.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • .release-plz.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workspace release configuration now sets git_release_draft = true. The release workflow runs x52-update-release-notes with the --then-undraft option.

Changes

Release draft handling

Layer / File(s) Summary
Draft release flow
.release-plz.toml, .github/workflows/release.yml
The workspace release configuration enables draft releases. The release-notes command adds --then-undraft.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3307a

The change creates releases as drafts, updates their notes, then publishes them. The tool revision pinned in the lock file supports the new option. No remaining merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: publish release-plz releases after updating release notes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robjtede
robjtede added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit 804c320 Oct 8, 2026
9 checks passed
@robjtede
robjtede deleted the chore/undraft-releases branch October 8, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant