Skip to content

Declare Rust MSRV and warn against distro-packaged toolchains #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnonRish wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Declare Rust MSRV and warn against distro-packaged toolchains #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions phoenix/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ members = [

[workspace.package]
edition = "2024"
rust-version = "1.85"

[workspace.dependencies]
anyhow = { version = "1", features = ["backtrace"] }
Expand Down
8 changes: 6 additions & 2 deletions phoenix/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,12 @@ apt update && apt install build-essential cmake pkg-config unzip \
```

Then install [uv](https://docs.astral.sh/uv/getting-started/installation/), a
Rust toolchain (<https://rustup.rs>) and `protoc` >= 3.15 (the protos use
proto3 `optional`, which older `protoc` rejects — Ubuntu 22.04's
Rust toolchain (<https://rustup.rs>) — this workspace uses the 2024 edition,
which needs rustc **1.85 or newer**; your distribution's packaged `rustc`/
`cargo` is very likely too old (Ubuntu 24.04 ships 1.75) and will fail with a
confusing `feature edition2024 is required` error rather than a clear version
message, so install via rustup rather than `apt` — and `protoc` >= 3.15 (the
protos use proto3 `optional`, which older `protoc` rejects — Ubuntu 22.04's
`protobuf-compiler` is 3.12, too old). Install the official release binary
once to a system path:

Expand Down