Skip to content

Fix panic on empty user_ids in RetrieveTopKCandidatesRequest #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnonRish wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Fix panic on empty user_ids in RetrieveTopKCandidatesRequest #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion phoenix/crates/serving/xai-recsys-engine/src/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2824,7 +2824,14 @@ impl RecsysRetrievalPredictorImpl {
})?;
let _in_flight_guard = InFlightGuard::new();

let user_id = request.user_ids.pop().unwrap();
let Some(user_id) = request.user_ids.pop() else {
NUM_REQUESTS_REJECTED
.with_label_values(&["invalid_argument", client.as_str()])
.inc();
return Err(Status::invalid_argument(
"RetrieveTopKCandidatesRequest.user_ids must not be empty",
));
};
let sequence = request.sequences.pop();
let topic_entity_ids = request.topic_entity_ids;
let topic_filter_mode = request.topic_filter_mode.unwrap_or(0);
Expand Down