CP-53843: reusable SM session#7002
Open
GabrielBuica wants to merge 4 commits intoxapi-project:masterfrom
Open
Conversation
Member
|
This seems like it would fix some issues I've seen in XCP-ng customers, but it's difficult to tell with the very short description, could you explain a bit further of what's the effect? In particular, the problem is that some sessions used for long-running migrations are being evicted from the cache because of the amount of new sessions being created by SM. |
added 4 commits
April 13, 2026 15:02
`exec_with_new_*` function create orphaned traces for subtasks with parents not in the database. This is meant to address this and link these spans to their correct parent. Signed-off-by: Gabriel Buica <danutgabriel.buica@citrix.com>
refactor the code before implementing reusable sessions for `sm_exec` Signed-off-by: Gabriel Buica <danutgabriel.buica@citrix.com>
The session reuse logic in `xapi_session.ml` does work in this usecase, sm calls are made with `pool=false`. So reimplement the logic so that we use a single session for `sm_exec`. This should help with session count inside xapi. Signed-off-by: Gabriel Buica <danutgabriel.buica@citrix.com>
Signed-off-by: Gabriel Buica <danutgabriel.buica@citrix.com>
GabrielBuica
force-pushed
the
private/dbuica/CP-53843
branch
from
2efe3c2 to
244b3a1
Compare
lindig
approved these changes
Apr 13, 2026
|
|
||
| let create_session ~__context = | ||
| let host = !Xapi_globs.localhost_ref in | ||
| let session = |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #6991
This is meant to reuse the same xapi session for sm_exec calls.