feat(fileshare): the skill catches up with the tool - #75
Merged
Conversation
`xentral_fileshare` grew three actions (xentral/agent-os#150, #151): a windowed `read` (offset/limit over lines, streamed), `find` (substring/regex with context and capped hits), and `update` (whole-body or an anchored patch). The skill still listed all three under "what this tool cannot do", which is worse than saying nothing: an agent that believes a file is unreadable reports failure instead of windowing it. - Actions section covers the new parameters and what each response reports. - "A big file" replaces "when read will not give you the file": three routes — window when you know where to look, find when you do not, import_analyze when a *figure* is wanted — plus the duty to pass on "more follows" and "stopped at max_hits" instead of papering over them. Only a binary over the cap has no route. - New "Overwriting" section: what may be overwritten (your own uploads), what needs the user to have asked for that file, and that an inbound email attachment never is. Plus the rules that are not about the file: an overwrite is its own step, anchors are exact, and you cannot replace the body of a file you could not read whole. - Recipes for the two new flows (locate something in a huge file; fix one line), and pitfalls for the three new ways to be confidently wrong. The remaining limits table is now short and true: no folders, no versions, no Office extraction, no binary edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
xentral_filesharegained three actions inxentral/agent-os(#150 windowedread+find, #151update). The skill still listed all three under "what this tool cannot do" — which is worse than silence: an agent that believes a large file is unreadable reports failure to the user instead of windowing it.What changed
readdocumentsoffset/limitand what the window response reports;findandupdateare added.readwill not give you the file". Three routes — window when you know where to look,findwhen you don't,import_analyzewhen a figure is wanted (still the only honest source for a count, even on a small table) — plus the duty to pass on "more follows" and "stopped atmax_hits" rather than papering over them. Only a binary over the cap has no route left.confirmed=true); an inbound email attachment never is. Plus the rules that aren't about the file — an overwrite is its own step, anchors must be unique, and you cannot replace the body of a file you could not read whole.The remaining limits table is now short and true: no folders, no versions, no Office extraction, no binary edit.
Verification
offset,find,confirmed=true, the inbox rule, the new recipe, the "stopped at" duty).python scripts/validate_library.py→ OK: 337 library items valid against their schemas.After merge
Tag, then
make bump-libraryin the backend. The two agent-os PRs can merge independently; until the bump, the vendored skill understates the tool (it does not misstate it in a way that breaks anything — it just tells the agent to give up early, which is the bug being fixed here).