feat(metadata): add cc flag parser

[MeteorsLiu]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces a new cc package for parsing C/C++ build metadata flags into a structured format, including support for sysroot extraction and linker flag identification. Feedback identifies a bug where linker flags followed by a space (e.g., -L /path) result in the argument being miscategorized as a compiler flag. Additionally, the CFLAGS field in the Metadata struct is currently unused and should either be populated or removed to avoid confusion.

[codecov]

Codecov Report

❌ Patch coverage is 93.80531% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.48%. Comparing base (9c6e52a) to head (bfd8a58).

Files with missing lines	Patch %	Lines
x/metadata/cc/cc.go	93.80%	5 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   79.69%   80.48%   +0.78%     
==========================================
  Files          35       36       +1     
  Lines        1921     2034     +113     
==========================================
+ Hits         1531     1637     +106     
- Misses        285      290       +5     
- Partials      105      107       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MeteorsLiu]

/review

[MeteorsLiu]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces the cc package to parse C/C++ build metadata flags into a structured Metadata object, including logic to categorize flags for compilation, linking, and sysroot. Feedback focuses on improving adherence to Go naming conventions for the Metadata struct and unifying field visibility. Several opportunities for code cleanup were also identified, such as removing unused constants, eliminating redundant string splitting for linker flags, and simplifying the sysroot assignment logic.

[luoliwoshang]

/review

[fennoai]

Review Summary

Clean, well-structured Go package for parsing C/C++ compiler flags. The code is idiomatic, the test suite is thorough, and the separation between parsing and classification is well done. A few observations below — mostly minor.

[fennoai]

The comments for CFLAGS and CXXFLAGS say "flags that apply specifically to C/C++ compilation," but in practice only -std flags (with C or C++ standard values) are routed here — no other C/C++-specific flags get classified separately. This could mislead consumers into expecting e.g. -Wstrict-prototypes to land in CFLAGS. Consider narrowing the wording, e.g.:

// CFLAGS contains -std flags with C language standard values (e.g. c99, gnu11).

[luoliwoshang]

LGTM