Skip to content

feat(cmd): support matrix require and option flags#114

Merged
luoliwoshang merged 1 commit into
xgo-dev:mainfrom
MeteorsLiu:design/matrix-cli
May 27, 2026
Merged

feat(cmd): support matrix require and option flags#114
luoliwoshang merged 1 commit into
xgo-dev:mainfrom
MeteorsLiu:design/matrix-cli

Conversation

@MeteorsLiu

@MeteorsLiu MeteorsLiu commented May 27, 2026

Copy link
Copy Markdown
Collaborator

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the matrix flag parsing logic to support --require and --option flags instead of the previous --matrix- prefix, and updates the corresponding unit tests. The review feedback points out a critical issue where specifying multiple --require or --option flags for the same key overwrites previous values instead of appending them, and provides suggestions to append the values to correctly support multi-value matrix dimensions.

Comment thread cmd/llar/internal/matrix_flags.go Outdated
Comment thread cmd/llar/internal/matrix_flags.go Outdated
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.43%. Comparing base (927b834) to head (bfdbed1).

Files with missing lines Patch % Lines
cmd/llar/internal/matrix_flags.go 87.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   80.47%   80.43%   -0.05%     
==========================================
  Files          37       37              
  Lines        2095     2116      +21     
==========================================
+ Hits         1686     1702      +16     
- Misses        297      300       +3     
- Partials      112      114       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Clean refactoring that replaces the --matrix- prefix approach with explicit --require and --option flags. Good test coverage and proper error handling. A few observations below — mostly around clarifying behavior and reducing duplication.

Comment thread cmd/llar/internal/matrix_flags.go
Comment thread cmd/llar/internal/matrix_flags.go
Comment thread cmd/llar/internal/matrix_flags.go Outdated
Comment thread cmd/llar/internal/matrix_flags.go
@MeteorsLiu MeteorsLiu force-pushed the design/matrix-cli branch from 8938758 to bfdbed1 Compare May 27, 2026 05:13
@MeteorsLiu MeteorsLiu requested a review from luoliwoshang May 27, 2026 05:17

@luoliwoshang luoliwoshang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luoliwoshang luoliwoshang merged commit f1a02d8 into xgo-dev:main May 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants