Skip to content

Fix units mismatch in picture metadata limit checks #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyder365 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix units mismatch in picture metadata limit checks #912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libFLAC/stream_decoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,7 +2230,7 @@ FLAC__bool read_metadata_picture_(FLAC__StreamDecoder *decoder, FLAC__StreamMeta
/* read MIME type */
if(!FLAC__bitreader_read_raw_uint32(decoder->private_->input, &x, FLAC__STREAM_METADATA_PICTURE_MIME_TYPE_LENGTH_LEN))
return false; /* read_callback_ sets the state for us */
if(FLAC__bitreader_limit_remaining(decoder->private_->input) < x){
if(FLAC__bitreader_limit_remaining(decoder->private_->input) < (FLAC__uint64)x * 8){
FLAC__bitreader_limit_invalidate(decoder->private_->input);
return false;
}
Expand All @@ -2247,7 +2247,7 @@ FLAC__bool read_metadata_picture_(FLAC__StreamDecoder *decoder, FLAC__StreamMeta
/* read description */
if(!FLAC__bitreader_read_raw_uint32(decoder->private_->input, &x, FLAC__STREAM_METADATA_PICTURE_DESCRIPTION_LENGTH_LEN))
return false; /* read_callback_ sets the state for us */
if(FLAC__bitreader_limit_remaining(decoder->private_->input) < x){
if(FLAC__bitreader_limit_remaining(decoder->private_->input) < (FLAC__uint64)x * 8){
FLAC__bitreader_limit_invalidate(decoder->private_->input);
return false;
}
Expand Down Expand Up @@ -2280,7 +2280,7 @@ FLAC__bool read_metadata_picture_(FLAC__StreamDecoder *decoder, FLAC__StreamMeta
/* read data */
if(!FLAC__bitreader_read_raw_uint32(decoder->private_->input, &(obj->data_length), FLAC__STREAM_METADATA_PICTURE_DATA_LENGTH_LEN))
return false; /* read_callback_ sets the state for us */
if(FLAC__bitreader_limit_remaining(decoder->private_->input) < obj->data_length){
if(FLAC__bitreader_limit_remaining(decoder->private_->input) < (FLAC__uint64)obj->data_length * 8){
FLAC__bitreader_limit_invalidate(decoder->private_->input);
return false;
}
Expand Down
Loading