rocksdb: fix build

[apocelipes]

RocksDB now requires a C++20 compatible compiler (GCC >= 11, Clang >= 10, Visual Studio >= 2019), including for any code using RocksDB headers.

Fixes #8608

[gemini-code-assist]

Summary of Changes

Hello @apocelipes, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a build issue for RocksDB by updating its package configuration. It introduces support for the latest RocksDB version, v10.7.5, and dynamically adjusts the required C++ standard during compilation. This ensures that newer RocksDB versions, which now mandate C++20, are built correctly, while maintaining compatibility with C++17 for older versions, thereby fixing the problem reported in issue #8608.

Highlights

• RocksDB Version Update: Added support for RocksDB version v10.7.5 to the package definition.
• Dynamic C++ Standard Configuration: Implemented a conditional logic to set the C++ standard for RocksDB builds: versions 10.7.0 and newer will now use C++20, while older versions will continue to use C++17. This addresses the updated compiler requirements for newer RocksDB releases.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the rocksdb package to support newer versions that require C++20. A new version v10.7.5 is added, and the test snippet is correctly configured to use C++20 for versions >= 10.7.0.

However, the change is incomplete as it doesn't update the main build configuration in on_install to use C++20, which will likely cause build failures for these newer versions. I've left a comment with a suggestion on how to fix this. I also pointed out a minor maintainability improvement regarding a magic version string.