Chapter 1-3: Assignment #5#7
Open
postmeback wants to merge 13 commits into
Open
Conversation
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
radumarias
requested changes
Feb 19, 2025
Member
radumarias
left a comment
radumarias
left a comment
There was a problem hiding this comment.
very good solution, congrats
just out of curiosity, could you also print the time it takes for each count?
and would be great if you could integrate https://crates.io/crates/criterion because that shows nice numbers and charts too as HTML. if you integrate this you need to extract in a function just the part that generates rand and remove from the vec, and just benchmark that, we we mostly care about this part
Author
|
This is the output coming up, however, after implementing criterion,no such benchmark is appearing. I have updated the code base. Please have a look. |
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
Signed-off-by: Arka Poddar <poddararka27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the solution for Chapter 1-3 assignment.
Issue reference: #5