[WIP] Fix connection issue with uvloop and SOCKS5#12
Merged
Conversation
…s configured Co-authored-by: xrh0905 <29017419+xrh0905@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical incompatibility issue between uvloop and SOCKS5 proxy configuration. The root cause is that SOCKS5 implementation monkey-patches socket.socket with socks.socksocket, which conflicts with uvloop's native socket implementation, causing connection failures when both features are enabled simultaneously.
Key Changes:
- Added a pre-check in
try_setup_uvloop()to detect SOCKS5 configuration before setting up uvloop - When SOCKS5 is active, uvloop setup is skipped with an informative error message
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot stopped work on behalf of
xrh0905 due to an error
December 9, 2025 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix uvloop + SOCKS5 Connectivity Issue
Analysis
Root Cause
The issue occurs because:
apply_upstream_proxy_settings()patchessocket.socketwithsocks.socksockettry_setup_uvloop()is called afterwards and sets up uvloop's event loopSolution
Modified
try_setup_uvloop()to detect SOCKS5 configuration and skip uvloop setup when SOCKS5 is active. When SOCKS5 is detected, a clear message is printed: "SOCKS5 proxy is configured, skipping uvloop (incompatible)"Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.