Skip to content

[WIP] Fix invalid tag format in Docker build #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrh0905 merged 2 commits into from
Dec 9, 2025
Merged

[WIP] Fix invalid tag format in Docker build #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6b052
Initial plan
Copilot Dec 9, 2025
9d32862
Fix invalid Docker tag format by restricting SHA tag generation
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=sha,prefix={{branch}}-
type=sha,prefix={{branch}}-,enable={{is_default_branch}}
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enable={{is_default_branch}} condition may not fully prevent the invalid tag issue. The {{branch}} placeholder is empty for tag push events (matching v*.*.*), which would still generate tags like -9f8980e with a leading hyphen.

Consider using event=push instead to only generate this tag for branch pushes:

type=sha,prefix={{branch}}-,event=push,enable={{is_default_branch}}

Alternatively, if you want SHA tags for all branch pushes (not just default branch), use:

type=sha,prefix={{branch}}-,event=push
Suggested change
type=sha,prefix={{branch}}-,enable={{is_default_branch}}
type=sha,prefix={{branch}}-,event=push,enable={{is_default_branch}}

Copilot uses AI. Check for mistakes.
type=raw,value=latest,enable=${{ github.ref == 'refs/heads/edge' }}

- name: Build and push Docker image
Expand Down