Path mis-match when git-dir with relative path elements provided #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaranmooney
force-pushed
the
pmd-path-mismatch
branch
from
d01470b to
cd97d2d
Compare
Owner
|
Thanks for your efforts to improving this project :-) @ciaranmooney |
Contributor
Author
Your welcome ... but wait! There's more! - #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling diff-pmd.jar with a git-dir path which had relative elements ("." or "..") would cause files with violations to pass the PMD checks.
This was caused by the DiffLineFilter diffEntry.getAbsoluteNewPath() String not matching the violation.getFilename(). It seems that the RuleViolation getFilename uses the unique Canonical paths but the File getAbsolutePath is the non-unique Abstract path. Eg. "/some/directory/file" vs "/some/directory/./file" (or "/some/../some/directory/file").
The DiffCalculatorTest was updated as the file equality was comparing by abstract paths and subsequently failing on Windows. This was due to Windows truncating file paths (C:\Users\CiaranMooney\file vs C:\Users\CiaranM~1\file).
Also, turns out Edit instances of different types are really easy to create. So I thought I'd remove the mocking for an actual instance.