feat!: y18n is now ESM first - #173
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
The rimraf interface changed from rimraf@3 to rimraf@6. The tests were failing because the cleanup of Next: sort out the linting... |
This comment was marked as resolved.
This comment was marked as resolved.
Switch from rimraf to simple built-in rmSync Switch from standardx to gts for linting
shadowspawn
force-pushed
the
feature/esm-first
branch
from
June 27, 2025 05:31
c6b67c5 to
026ee84
Compare
Member
Author
|
Two of the less trivial changes prompted by linter were: Replace use of Replace in - return this.__.apply(this, [str].concat([].slice.call(args, 1)))
+ return this.__(str, ...args.slice(1)); |
- remove standard badge as no longer using standard
shadowspawn
marked this pull request as ready for review
July 11, 2025 04:04
Member
Author
|
I reworked README for esm. Similar to yargs, code examples use |
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop shipping dual esm/cjs. Ship just esm and rely on require(esm) support in recent versions of node to support CJS users.
Following yargs moving from dual CJS/ESM to ESM-only: yargs/yargs#2451
Rework lint setup to closely follow setup in yargs/yarg: essentially switching from standardx to gts.
Lots of noise in "Files changed" due to linting changes, but can look at the first commit for the bulk of the esm changes.
Includes fix for module entry point:
moduleandexportsare mismatched. #155module#156