-
Notifications
You must be signed in to change notification settings - Fork 17
chore: set engines, regenerate package lock with npm 10 #3166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4984f0 to
35b426d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Node.js and npm engine requirements to the package.json and regenerates the package-lock.json file with npm 10. The changes ensure that the project explicitly declares its runtime requirements and updates the lockfile structure to match npm 10's format.
- Adds
enginesfield specifying Node.js >=22.0 and npm ^10.9.2 - Regenerates package-lock.json with npm 10, which updates peer dependency markers and package metadata
- No functional code changes or dependency version updates
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Adds engines field to specify Node.js >=22.0 and npm ^10.9.2 requirements |
| package-lock.json | Regenerated with npm 10, updating peer dependency markers and internal structure without changing dependency versions |
package.json
Outdated
| "main": "dist/lib.js", | ||
| "engines": { | ||
| "node": ">=22.0", | ||
| "npm": "^10.9.2" |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The npm version constraint is overly restrictive. Using ^10.9.2 will only allow patch updates (e.g., 10.9.3, 10.9.4) but will exclude minor version updates (e.g., 10.10.x, 10.11.x) that typically include bug fixes and improvements.
Consider using ^10.0.0 to allow all npm 10.x versions, or at minimum >=10.9.2 if there's a specific feature requirement from 10.9.2.
| "npm": "^10.9.2" | |
| "npm": "^10.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
35b426d to
151c4c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
151c4c9 to
d7bf8c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.34 MB | Main: 62.34 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information