-
Notifications
You must be signed in to change notification settings - Fork 17
fix: github action fix #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: github action fix #3172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to update the Node.js version used in the GitHub Actions publication workflow from version 22 to version 24. However, this change introduces a critical issue as Node.js version 24 does not exist yet.
Key Changes
- Updates
node-versionin the publication workflow from 22 to 24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Node version should be 22, not 24. The .nvmrc file specifies v22 and ci.yml uses Node 22. This creates version inconsistency across workflows.
| node-version: 24 | |
| node-version: 22 |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/publication.yml
Line: 21:21
Comment:
**logic:** Node version should be 22, not 24. The `.nvmrc` file specifies `v22` and `ci.yml` uses Node 22. This creates version inconsistency across workflows.
```suggestion
node-version: 22
```
How can I resolve this? If you propose a fix, please make it concise.
Greptile Overview
Greptile Summary
This PR updates the Node.js version in the publication workflow from 22 to 24, which introduces an inconsistency with the project's configuration.
Critical Issue:
.nvmrcfile specifies Nodev22as the project standardci.ymlworkflow uses Node 22 for all builds and testsImpact:
Confidence Score: 1/5
.nvmrcandci.yml). This creates environment inconsistency between CI testing and production publishing, which could lead to version-specific issues appearing only in releases..github/workflows/publication.ymlrequires correction - Node version should be 22 to match project configurationImportant Files Changed
File Analysis
.nvmrc(v22) and other workflows (ci.yml uses v22)Sequence Diagram
sequenceDiagram participant Release as GitHub Release Event participant Workflow as Publication Workflow participant Node as Node.js 24 Setup participant NPM as NPM Registry participant GH as GitHub Release participant Dispatch as Repository Dispatch Release->>Workflow: Trigger on release Workflow->>Workflow: Checkout code Workflow->>Node: Setup Node.js v24 Node->>Workflow: Environment ready Workflow->>Workflow: npm ci (install dependencies) Workflow->>NPM: npm publish NPM-->>Workflow: Package published Workflow->>Workflow: npm run build:embedded:archive Workflow->>GH: Upload embedded-ui.zip to release GH-->>Workflow: Asset uploaded Workflow->>Dispatch: Trigger embedded_ui_refresh event Dispatch-->>Workflow: Event dispatched to ydb-platform/ydbCI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.34 MB | Main: 62.34 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information