Skip to content

Conversation

@Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Dec 3, 2025

Greptile Overview

Greptile Summary

This PR updates the Node.js version in the publication workflow from 22 to 24, which introduces an inconsistency with the project's configuration.

Critical Issue:

  • The .nvmrc file specifies Node v22 as the project standard
  • The ci.yml workflow uses Node 22 for all builds and tests
  • This change to Node 24 creates version mismatch across the project's CI/CD pipelines

Impact:

  • Publications may use different Node.js version than what was tested in CI
  • Potential for version-specific bugs that only appear in production releases
  • Violates the principle of environment consistency between testing and deployment

Confidence Score: 1/5

  • This PR introduces a critical configuration inconsistency that should be corrected before merging
  • The change sets Node.js version to 24 in the publication workflow, but the project uses Node 22 everywhere else (.nvmrc and ci.yml). This creates environment inconsistency between CI testing and production publishing, which could lead to version-specific issues appearing only in releases.
  • .github/workflows/publication.yml requires correction - Node version should be 22 to match project configuration

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/publication.yml 1/5 Changed Node.js version from 22 to 24, which is inconsistent with .nvmrc (v22) and other workflows (ci.yml uses v22)

Sequence Diagram

sequenceDiagram
    participant Release as GitHub Release Event
    participant Workflow as Publication Workflow
    participant Node as Node.js 24 Setup
    participant NPM as NPM Registry
    participant GH as GitHub Release
    participant Dispatch as Repository Dispatch

    Release->>Workflow: Trigger on release
    Workflow->>Workflow: Checkout code
    Workflow->>Node: Setup Node.js v24
    Node->>Workflow: Environment ready
    Workflow->>Workflow: npm ci (install dependencies)
    Workflow->>NPM: npm publish
    NPM-->>Workflow: Package published
    Workflow->>Workflow: npm run build:embedded:archive
    Workflow->>GH: Upload embedded-ui.zip to release
    GH-->>Workflow: Asset uploaded
    Workflow->>Dispatch: Trigger embedded_ui_refresh event
    Dispatch-->>Workflow: Event dispatched to ydb-platform/ydb
Loading

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 62.34 MB | Main: 62.34 MB
Diff: 0.00 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copilot AI review requested due to automatic review settings December 3, 2025 12:18
Copilot finished reviewing on behalf of Raubzeug December 3, 2025 12:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to update the Node.js version used in the GitHub Actions publication workflow from version 22 to version 24. However, this change introduces a critical issue as Node.js version 24 does not exist yet.

Key Changes

  • Updates node-version in the publication workflow from 22 to 24

@Raubzeug Raubzeug enabled auto-merge December 3, 2025 12:20
@Raubzeug Raubzeug changed the title fix: GA fix fix: github action fix Dec 3, 2025
@Raubzeug Raubzeug added this pull request to the merge queue Dec 3, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Node version should be 22, not 24. The .nvmrc file specifies v22 and ci.yml uses Node 22. This creates version inconsistency across workflows.

Suggested change
node-version: 24
node-version: 22
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/publication.yml
Line: 21:21

Comment:
**logic:** Node version should be 22, not 24. The `.nvmrc` file specifies `v22` and `ci.yml` uses Node 22. This creates version inconsistency across workflows.

```suggestion
          node-version: 22
```

How can I resolve this? If you propose a fix, please make it concise.

Merged via the queue into main with commit 9cc02d1 Dec 3, 2025
8 of 9 checks passed
@Raubzeug Raubzeug deleted the release2 branch December 3, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants