#197: WIP WIP WIP Pass Db and Tx in transaction body lambda parameters WIP WIP WIP #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s WIP WIP WIP Very very experimental atm. Problems: - Not especially nice to use compared to @Inject'ing your Db implementation (that is just BaseDb.current()) /Using BaseDb.current() directly. - Function<Db, R> and Consumer<Db> are lambda signature-compatible, this leads to unability to have the same tx() name for both methods, and we get ScopedTxManager.call() and ScopedTxManager.run(), which is sub-optimal - Even if we only have one Function<Db,R>-taking method in ScopedManager, we get generics hell with AssertJ's assertThat(): results of Function<Db,R>-taking method are considered by javac to be compatible with almost every interface argument that assertThat() takes! - ReadOnlyBuilder/ScanBuilder are not supported (yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very very experimental atm. Problems: