Repository navigation
Skip per-visit work that a visit can't need - #189
Merged
Merged
Conversation
…nd leaf searches An element whose only child is text on both sides now morphs that text directly instead of building the sibling lists and running every matching pass. Claiming a movable element only walks up to its select once there's a live element to claim, and inserting a node skips the select and form searches when it has no element children. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJNvudrTrB2rfJaLWKRMsc
joeldrapper
marked this pull request as ready for review
October 7, 2026 16:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joel · project thread
Before: every visited element built its sibling lists and ran every matching pass, even when its only child was a text node on both sides. Every target looked up its enclosing select before checking whether there was a live element to claim, and every inserted node searched for selects and forms even when it had no element children.
After: those visits skip that work. Editing every row of a 1000-item list is 30–41% faster, and no benchmark scenario got slower.
The matching result doesn't change. An element whose only child is text on both sides (both whitespace or both not) morphs the text directly, which is the pair the passes would pick anyway.
How:
visitChildNodeshas a fast path for a single text child.#canClaimand#claimMovableElementonly look up the select once they have a claimable live element.clearImplicitSelection,#uncheckRadiosNamingFormsInand#uncheckRadiosInFormsInreturn early for leaves.Coverage is 100%. A deep fuzz run passed locally: 5,000 matching, 2,000 preserve, 5,000 tree, 3,000 move and 5,000 form-state seeds.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VJNvudrTrB2rfJaLWKRMsc
Generated by Claude Code