Repository navigation
Restore documented Nextion.encoding property - #37
Merged
Merged
Conversation
The README documents client.encoding for switching the serial codec at runtime, but the client only had a private _encoding attribute, so the assignment silently did nothing. Expose it as a property and document that it must match the project's character set. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
# Conflicts: # tests/test_client.py
…load notes Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #23
Problem
README documents
client.encoding = 'latin-1'andprint(client.encoding), butNextiononly had_encoding. Assigningclient.encodingcreated an unused attribute, so commands kept encoding as ASCII and non-ASCII text such as°failed.Change
encodingproperty (getter/setter over_encoding), used for both outgoing commands and incoming string replies.Tests
test_encoding_setter_is_used_for_commands: default isascii; afterclient.encoding = 'latin-1',getdecodes21°Candsetsendsb't0.txt="21\xb0C"'. Fails on master withAttributeError.pytest: 65 passed. black/flake8 clean.Not verified
The scrolling-text component behaviour reported in #23 was not reproduced (no hardware), so this PR does not close #23.