Skip to content

chore: never proactively commit or push without explicit request#2584

Merged
ymc9 merged 1 commit into
devfrom
chore/no-proactive-git-ops
Apr 17, 2026
Merged

chore: never proactively commit or push without explicit request#2584
ymc9 merged 1 commit into
devfrom
chore/no-proactive-git-ops

Conversation

@ymc9
Copy link
Copy Markdown
Member

@ymc9 ymc9 commented Apr 17, 2026

Summary

  • Adds a Git Workflow section to CLAUDE.md instructing Claude Code to never commit or push changes unless explicitly asked to do so.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated development workflow documentation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 17, 2026

Claude finished @ymc9's task —— View job


PR Review Complete

Todo List:

  • Read the modified CLAUDE.md file to understand the changes
  • Analyze the documentation change for quality and appropriateness
  • Provide comprehensive review feedback
  • Submit final review

Review Summary

This PR adds a clear and important instruction to prevent Claude Code from making proactive git operations. The change is minimal, well-placed, and addresses a legitimate concern.

Code Quality & Best Practices ✅

Strengths:

  • Clear and concise: The instruction is unambiguous and easy to understand
  • Appropriate placement: The "Git Workflow" section logically fits between "Pull Requests" and "Development Notes"
  • Consistent formatting: Follows the existing markdown structure and bullet point style used throughout the file
  • Proper section hierarchy: Uses ## heading level consistent with other major sections

Documentation Quality ✅

Strengths:

  • Specific and actionable: The instruction clearly states what NOT to do
  • Consistent with existing content: Aligns with the existing "Pull Requests" section that gives specific git-related guidance
  • Maintains document flow: Doesn't disrupt the logical organization of the file

Potential Improvements 🔍

Minor suggestions:

  1. Consider expanding the instruction: While "unless explicitly asked to do so" is clear, you might consider being more specific about what constitutes an "explicit request" (e.g., "unless the user explicitly requests a commit or push operation")

  2. Consistency with existing section: The "Pull Requests" section above uses similar git-related guidance. Consider if these sections could be consolidated or if there's value in keeping them separate.

Security Considerations ✅

This change actually improves security by:

  • Preventing accidental commits of sensitive information
  • Ensuring user approval before any git operations
  • Reducing the risk of unintended changes to the repository

Performance & Test Coverage ✅

Not applicable - This is a documentation change that doesn't affect runtime performance or require test coverage.

Overall Assessment ✅

This is a straightforward, well-executed documentation improvement that addresses an important workflow concern. The change is minimal, clear, and properly integrated into the existing document structure.

Recommendation: Approve and merge - This is a valuable addition that will help prevent unintended git operations by Claude Code.

@ymc9 ymc9 merged commit c9b5c53 into dev Apr 17, 2026
6 of 7 checks passed
@ymc9 ymc9 deleted the chore/no-proactive-git-ops branch April 17, 2026 02:29
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5e9d10db-afeb-4440-be32-e3c73a85a649

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd4951 and 8b6194d.

📒 Files selected for processing (1)
  • CLAUDE.md

📝 Walkthrough

Walkthrough

A new "Git Workflow" section was added to CLAUDE.md establishing a single guideline: changes must not be committed or pushed without explicit instruction to do so.

Changes

Cohort / File(s) Summary
Documentation
CLAUDE.md
Added new "Git Workflow" section with guidance on commit and push restrictions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Git commits, a careful dance,
Only when you give the chance,
Push not, pull not, hold the line,
Wait for words before I sign!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/no-proactive-git-ops

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant