tests: riscv Remove redundant z_riscv_pmp_read_config declaration #99525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: RISCV
zephyrbot
requested review from
VynDragon,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
nashif,
npitre,
tgorochowik and
ycsin
fsammoura1980
force-pushed
the
remove_redundant_header
branch
from
c8e25a2 to
25b5954
Compare
… test The function prototype for `z_riscv_pmp_read_config()` was previously declared in `tests/arch/riscv/pmp/clear-pmp-unlocked-entries/src/main.c`. This local declaration is no longer necessary as the prototype is now defined within the centralized PMP header, `include/arch/riscv/pmp.h`, which is already included via `kernel_internal.h`. The prototype is guarded by the `CONFIG_ZTEST` Kconfig option. Signed-off-by: Firas Sammoura <[email protected]>
fsammoura1980
force-pushed
the
remove_redundant_header
branch
from
25b5954 to
1bab0fb
Compare
|
jimmyzhe
approved these changes
Nov 20, 2025
fkokosinski
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function prototype for
z_riscv_pmp_read_config()was previously declared intests/arch/riscv/pmp/clear-pmp-unlocked-entries/src/main.c.This local declaration is no longer necessary as the prototype is now defined within the centralized PMP header,
include/arch/riscv/pmp.h, which is already included viakernel_internal.h. The prototype is guarded by theCONFIG_ZTESTKconfig option.