Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2626.
Depends on #2628. This stacked PR currently includes the prerequisite commit; the unique change is
4238024455f23866190d188ff6b97d38b0334280.Problem
The Windows TAP health check scans
GetAdaptersAddressesusing a fixed 16 KiB buffer. HNS can omit the raw TAP from that IP-adapter enumeration after moving IP protocol ownership to a management vNIC. The current loop then leavesisBorkedfalse and treats the omitted TAP as healthy. Enumeration errors, including buffer overflow, have the same effect.Change
GetIfEntry2directly with the TAP LUID already held byWindowsEthernetTap.IfOperStatusUpquery as healthy and other successful operational states as unhealthy.Validation
windows-tap-device-state: passed.GetAdaptersAddresseswhileGetIfEntry2continued to return its state by LUID.