This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Repository navigation
ast: don't add semicolons to static assertion blocks - #251
Merged
Merged
Conversation
Contributor
|
Dupe of 836ea03 (although it was somehow never merged into master ?) |
Contributor
Author
Contributor
|
Well, it was never merged on master so summoning @Vexu ! |
Member
|
Looks like I accidentally dropped that commit on rebase. I'll use this if you rebase it after #252 |
Contributor
Author
Sounds good. |
theofabilous
marked this pull request as draft
November 26, 2025 16:13
theofabilous
force-pushed
the
no-static-assert-semicolon
branch
from
November 26, 2025 16:16
da73449 to
10ae2f6
Compare
Co-authored-by: Veikka Tuominen <git@vexu.eu>
theofabilous
force-pushed
the
no-static-assert-semicolon
branch
from
November 26, 2025 16:36
10ae2f6 to
51668a8
Compare
Contributor
Author
theofabilous
marked this pull request as ready for review
November 26, 2025 16:39
Vexu
enabled auto-merge (rebase)
November 26, 2025 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220
_Static_asserts inside function bodies are rendered with a trailing semicolon, yielding syntactically invalid zig code.Fixed by not appending a semicolon to static assertions in
addSemicolonIfNeeded()