Skip to content

:chore: replace panics with proper error handling in WASM bindings#42

Open
wryonik wants to merge 1 commit into
feat/new-compilerfrom
shubham/reg-65-handle-all-wasm-panics
Open

:chore: replace panics with proper error handling in WASM bindings#42
wryonik wants to merge 1 commit into
feat/new-compilerfrom
shubham/reg-65-handle-all-wasm-panics

Conversation

@wryonik
Copy link
Copy Markdown
Contributor

@wryonik wryonik commented Feb 16, 2026

Description

Remove all panic!(), unwrap(), and expect() calls from WASM bindings and functions called by them. Errors are now properly caught and converted to rejected Promises with descriptive messages instead of causing crashes.

Type of change

  • Refactor
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

NA

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wryonik wryonik requested review from BornPsych and rutefig February 16, 2026 17:56
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shubham/reg-65-handle-all-wasm-panics

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wryonik wryonik force-pushed the shubham/reg-65-handle-all-wasm-panics branch from a2e0034 to b6ce5d7 Compare February 16, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant