Skip to content

ui: say when the vault check could not reach the node - #216

Merged
mellowcroc merged 1 commit into
mainfrom
fix/vault-check-unavailable
Nov 6, 2026
Merged

mellowcroc merged 1 commit into
mainfrom
fix/vault-check-unavailable

Conversation

@mellowcroc

Copy link
Copy Markdown
Collaborator

When the Mina node doesn't answer the live permission check, pages now show "Couldn't verify this Vault right now" instead of "Unsafe Vault", and re-check every 15 seconds. Actions stay blocked exactly as before.

Unit tests plus a new UI e2e case for a 502 from the node.

🤖 Generated with Claude Code

The live permission check returns null when the Mina node does not
answer (HTTP error, GraphQL errors, network failure). Every page treated
that as a failed check and showed "Unsafe Vault ... Do not fund or use
this account", so a node outage looked like a compromised vault.

useVaultSecurity now reports 'unavailable' for a null result and
re-checks every 15 seconds, so pages recover without a reload. The
notice shows an amber "Couldn't verify this Vault right now" message
when the backend has verified the vault and only the live lookup
failed. Click-time checks say the node could not be reached instead of
naming the vault as non-canonical.

Actions stay blocked exactly as before: 'unavailable' is not 'safe',
and isCanonicalVaultSecurity(null) is still false. The proposal page's
SubVault check now uses the same hook, so it retries too.
@mellowcroc
mellowcroc merged commit ccbb519 into main Nov 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant