Repository navigation
ui: say when the vault check could not reach the node - #216
Merged
Merged
Conversation
The live permission check returns null when the Mina node does not answer (HTTP error, GraphQL errors, network failure). Every page treated that as a failed check and showed "Unsafe Vault ... Do not fund or use this account", so a node outage looked like a compromised vault. useVaultSecurity now reports 'unavailable' for a null result and re-checks every 15 seconds, so pages recover without a reload. The notice shows an amber "Couldn't verify this Vault right now" message when the backend has verified the vault and only the live lookup failed. Click-time checks say the node could not be reached instead of naming the vault as non-canonical. Actions stay blocked exactly as before: 'unavailable' is not 'safe', and isCanonicalVaultSecurity(null) is still false. The proposal page's SubVault check now uses the same hook, so it retries too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Mina node doesn't answer the live permission check, pages now show "Couldn't verify this Vault right now" instead of "Unsafe Vault", and re-check every 15 seconds. Actions stay blocked exactly as before.
Unit tests plus a new UI e2e case for a 502 from the node.
🤖 Generated with Claude Code