fix(sequence): correctly detect padding for frames with no leading zeros#245
Closed
VIKASKENDRE wants to merge 1 commit intoAcademySoftwareFoundation:developfrom
Closed
Conversation
pad_size() returned 0 when the integer's natural string representation
matched the frame string length (e.g. "1000" -> to_string(1000) == "1000").
This produced {:00d} URIs for sequences like shot.1000.exr, causing all
frames to fail loading after the first.
The padding width is always the length of the frame string regardless of
whether leading zeros are present, so simply return frame.size().
Fixes AcademySoftwareFoundation#152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #152
pad_size()returned0when a frame number's natural string representation matched its string length (e.g."1000"→to_string(1000)=="1000"), indicating "no leading zeros" but incorrectly treating it as unknown/zero padding{:00d}URIs for sequences likeshot.1000.exr, causing xSTUDIO to fail loading all frames after the first withUnsupported file typewarningsframe.size()