Skip to content

fix(sequence): correctly detect padding for frames with no leading zeros #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VIKASKENDRE wants to merge 1 commit into from
+5 −3
Closed

fix(sequence): correctly detect padding for frames with no leading zeros #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/utility/src/sequence.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,11 @@ std::vector<Sequence> default_collapse_sequences(const std::vector<Entry> &entri
}

int pad_size(const std::string &frame) {
// -01 == pad 3
// 0 pad means unknown padding
return (std::to_string(std::atoi(frame.c_str())).size() == frame.size() ? 0 : frame.size());
// The padding width is always the length of the frame string.
// e.g. "0001" -> 4, "1000" -> 4, "-01" -> 3, "" -> 0 (unknown)
// Previously, frames with no leading zeros (e.g. "1000") incorrectly
// returned 0, producing {:00d} URIs that failed to load any frame.
return static_cast<int>(frame.size());
}

std::string pad_spec(const int pad) {
Expand Down
Loading