Skip to content

feat: Apply categorical coloring to lines - #303

Open
ShrimpCryptid wants to merge 5 commits into
feat/line-tooltipfrom
feat/line-category-colors
Open

feat: Apply categorical coloring to lines#303
ShrimpCryptid wants to merge 5 commits into
feat/line-tooltipfrom
feat/line-category-colors

Conversation

@ShrimpCryptid

@ShrimpCryptid ShrimpCryptid commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

This is the final PR in the line feature series! This feature takes the colors shown when coloring by a discrete/categorical feature and applies them to lines, when those lines are grouped by the same categorical feature. This makes it easier to distinguish the lines of different groups of points.

Estimated review size: small, 5-10 minutes

Solution

  • Used the getCategoryGroupColorsAndNames selector to get group colors in getLinePlotData.
  • Updated several types to include more metadata for mapping groups to colors.

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to Verify:

  1. Open PR preview: https://allencell.github.io/cell-feature-explorer/pr-preview/pr-303/?cellSelectedFor3D=2800&colorBy=trajectory_id&dataset=csv&csvUrl=https%253A%252F%252Fvast-files.int.allencell.org%252Fusers%252Fmajid.farhadloo%252F2026-07-23%252Fdetect_normal_abnormal_growth%252Flumenoid_laca_8593__frame_embeddings.csv&plotByOnX=pacmap_y&plotByOnY=pacmap_x&groupBy=trajectory_id&connectByCategory=trajectory_id&connectByFeature=timepoint&connectBy=true
  2. Note that the lines are colored! Click the gear icon in the plot view to adjust the opacity of the points; the opacity of the lines will also update.
  3. Change the connect by feature or the group by feature to a different feature. The colors will revert to a default dark grey.

Screenshots (optional):

{FFAD00AA-1562-4FF2-A07F-2738FF15FA22}

@ShrimpCryptid ShrimpCryptid self-assigned this Aug 13, 2026
@ShrimpCryptid ShrimpCryptid added the enhancement New feature or request label Aug 13, 2026
ShrimpCryptid
ShrimpCryptid commented Aug 13, 2026
View reviewed changes
Comment thread src/state/selection/selectors.ts
color: option.color,
name: id,
label: option.name,
key: Number.parseFloat(key),

@ShrimpCryptid ShrimpCryptid Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stores the key (value) of the group when calculating getCategoryGroupColorsAndNames

@github-actions

github-actions Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
PR Preview Action v1.6.3

🚀 View preview at
https://AllenCell.github.io/cell-feature-explorer/pr-preview/pr-303/

Built to branch gh-pages at 2026-08-20 18:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ShrimpCryptid
ShrimpCryptid marked this pull request as ready for review August 13, 2026 22:45
@ShrimpCryptid
ShrimpCryptid force-pushed the feat/line-category-colors branch 2 times, most recently from 31338c9 to c7dcd03 Compare August 17, 2026 20:44
@ShrimpCryptid ShrimpCryptid linked an issue Aug 18, 2026 that may be closed by this pull request
Line plots for time series #248
Open
@ShrimpCryptid
ShrimpCryptid force-pushed the feat/line-category-colors branch from c7dcd03 to 47a469e Compare August 20, 2026 17:44
@ShrimpCryptid
ShrimpCryptid force-pushed the feat/line-category-colors branch from 47a469e to f161ffb Compare August 20, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toloudis toloudis toloudis approved these changes
@frasercl frasercl Awaiting requested review from frasercl

Assignees

@ShrimpCryptid ShrimpCryptid

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Line plots for time series

2 participants

@ShrimpCryptid @toloudis