The 76#53
Conversation
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the Apocrypha XIII Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
FalloutFalcon
left a comment
FalloutFalcon
left a comment
There was a problem hiding this comment.
linter fail
Hella nits.
| const experienceNeeded = data.job_required_experience?.[name]; | ||
| const daysLeft = data.job_days_left ? data.job_days_left[name] : 0; | ||
|
|
||
|
|
| // APOC EDIT ADD START - JOBS - Ocean 76 | ||
| /* Ocean 76ers */ | ||
| /obj/effect/landmark/start/darkpack/ocean | ||
| name = "generic gang member start" | ||
| icon = 'modular_zapoc/modules/jobs/icons/landmarks.dmi' | ||
|
|
||
| JOB_START_HELPER(ocean/boss, JOB_OCEAN_76_BOSS) | ||
| JOB_START_HELPER(ocean/ganger, JOB_OCEAN_76_GANGER) | ||
| // APOC EDIT ADD END | ||
|
|
There was a problem hiding this comment.
Guh. That helper should just be put in a define folder so these can go with there module. (upstream issue)
There was a problem hiding this comment.
i can make a pr for this later, unless you want that made before this gets merged
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
2 participants
About The Pull Request
Adds the Ocean 76 gang as jobs and adds map landmarks for them.
Why It's Good For The Game
The Ocean 76 are important to our metaplot.
Changelog
🆑
add: The Ocean 76 gang
/:cl: