forked from DarkPack13/SecondCity
-
Notifications
You must be signed in to change notification settings - Fork 1
The 76 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dwinters99
wants to merge
13
commits into
ApocryphaXIII:master
Choose a base branch
from
dwinters99:76
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
The 76 #53
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
69ce18f
76
dwinters99 dcefe33
config tag
dwinters99 259605e
linter fail
dwinters99 199c26a
yeah whoops whatever sue me
dwinters99 3510e35
.
dwinters99 24450c1
gonna need this
dwinters99 1e9a830
Merge remote-tracking branch 'Apocrypha/master' into 76
dwinters99 6a78dbb
name pass
dwinters99 2670a89
n
dwinters99 6ac3e59
Apply suggestions from code review
dwinters99 72c046f
oop
dwinters99 02c1f76
Merge branch 'master' into 76
dwinters99 3d92e75
i have ideas
dwinters99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| #define FACTION_OCEAN_76 "ocean" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| // Ocean 76 | ||
| #define JOB_OCEAN_76_BOSS "Handler" | ||
| #define JOB_OCEAN_76_GANGER "Operator" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| /datum/job_department/ocean | ||
| department_name = DEPARTMENT_OCEAN | ||
| department_bitflags = DEPARTMENT_BITFLAG_GAIA | ||
| department_head = /datum/job/vampire/ocean_boss | ||
| department_experience_type = EXP_TYPE_OCEAN | ||
| display_order = 1 | ||
| label_class = "ocean" | ||
| ui_color = "#5d8694" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /datum/job/vampire/ocean_boss | ||
| title = JOB_OCEAN_76_BOSS | ||
| faction = FACTION_OCEAN_76 | ||
| total_positions = 1 | ||
| spawn_positions = 1 | ||
| supervisors = "the Arch" | ||
| config_tag = "OCEAN76BOSS" | ||
| job_flags = CITY_JOB_FLAGS | ||
| outfit = /datum/outfit/job/vampire/ocean | ||
|
|
||
| display_order = JOB_DISPLAY_ORDER_OCEAN_76_BOSS | ||
| exp_required_type_department = EXP_TYPE_OCEAN | ||
| department_for_prefs = /datum/job_department/ocean | ||
| departments_list = list( | ||
| /datum/job_department/ocean, | ||
| ) | ||
|
|
||
| known_contacts = list("Operator", "Dealer") | ||
| allowed_splats = list(SPLAT_NONE) | ||
| description = "This city should belong to those who live in it. Your operators are at your command, and they have your back." | ||
| minimal_masquerade = 5 | ||
|
|
||
| /datum/outfit/job/vampire/ocean_boss | ||
| name = "Handler" | ||
| jobtype = /datum/job/vampire/ocean | ||
| uniform = /obj/item/clothing/under/vampire/biker | ||
| shoes = /obj/item/clothing/shoes/vampire/sneakers | ||
| head = /obj/item/clothing/head/vampire/bandana/black | ||
| l_pocket = /obj/item/vamp/keys/ocean | ||
| r_pocket = /obj/item/knife/vamp | ||
| backpack_contents = list(/obj/item/clothing/suit/vampire/vest = 1, /obj/item/clothing/mask/vampire/balaclava = 1, /obj/item/gun/ballistic/automatic/pistol/darkpack/beretta = 1, /obj/item/ammo_box/magazine/semi9mm = 2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /datum/job/vampire/ocean | ||
| title = JOB_OCEAN_76_GANGER | ||
| faction = FACTION_OCEAN_76 | ||
| total_positions = 8 | ||
| spawn_positions = 8 | ||
| supervisors = "the Boss" | ||
| config_tag = "OCEAN76" | ||
| job_flags = CITY_JOB_FLAGS | ||
| outfit = /datum/outfit/job/vampire/ocean | ||
|
|
||
| display_order = JOB_DISPLAY_ORDER_OCEAN_76_GANGER | ||
| exp_required_type_department = EXP_TYPE_OCEAN | ||
| department_for_prefs = /datum/job_department/ocean | ||
| departments_list = list( | ||
| /datum/job_department/ocean, | ||
| ) | ||
|
|
||
| known_contacts = list("Handler") | ||
| description = "This city should belong to those who live in it. Run the streets the way they're supposed to be run." | ||
| minimal_masquerade = 0 | ||
|
|
||
| /datum/outfit/job/vampire/ocean | ||
| name = "Operator" | ||
| jobtype = /datum/job/vampire/ocean | ||
| uniform = /obj/item/clothing/under/vampire/biker | ||
| shoes = /obj/item/clothing/shoes/vampire/sneakers | ||
| head = /obj/item/clothing/head/vampire/bandana/black | ||
| l_pocket = /obj/item/vamp/keys/ocean | ||
| r_pocket = /obj/item/knife/vamp | ||
| backpack_contents = list(/obj/item/clothing/mask/vampire/balaclava = 1, /obj/item/gun/ballistic/automatic/pistol/darkpack/glock19 = 1, /obj/item/ammo_box/magazine/glock9mm = 2) |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -194,7 +194,6 @@ function JobRow(props: JobRowProps) { | |
| const experienceNeeded = data.job_required_experience?.[name]; | ||
| const daysLeft = data.job_days_left ? data.job_days_left[name] : 0; | ||
|
|
||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. non-modular edit lol |
||
| // DARKPACK EDIT ADD START - ALTERNATIVE_JOB_TITLES | ||
| const alt_title_selected = data.job_alt_titles[name] | ||
| ? data.job_alt_titles[name] | ||
|
|
@@ -400,6 +399,9 @@ export function JobsPage() { | |
| <Department department="Manor" /> | ||
| <Department department="Sabbat" /> | ||
| <Department department="Citizen" /> | ||
| {/* APOC EDIT ADD START - JOBS - Ocean 76 */} | ||
| <Department department="Ocean_76" /> | ||
| {/* APOC EDIT ADD END */} | ||
| <Department department="City_Services" /> | ||
| <Department department="Garou_Nation" /> | ||
| <Department department="Society_of_Leopold" /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guh. That helper should just be put in a define folder so these can go with there module. (upstream issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can make a pr for this later, unless you want that made before this gets merged