feat: Add react compiler behind a config #9782
Merged
+59
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cephalization
force-pushed
the
cephalization/react-19
branch
from
3ef4416 to
3a3bb56
Compare
cephalization
force-pushed
the
cephalization/react-compiler
branch
2 times, most recently
from
c06ee9f to
d16f9f3
Compare
cephalization
force-pushed
the
cephalization/react-19
branch
from
0e8d802 to
a8dc254
Compare
cephalization
force-pushed
the
cephalization/react-compiler
branch
from
d16f9f3 to
d0eb886
Compare
cephalization
force-pushed
the
cephalization/react-compiler
branch
2 times, most recently
from
649ffa1 to
591ad27
Compare
cephalization
force-pushed
the
cephalization/react-19
branch
from
3e51f6d to
8f866cf
Compare
cephalization
force-pushed
the
cephalization/react-compiler
branch
from
b20cdc1 to
b45e114
Compare
cephalization
force-pushed
the
cephalization/react-19
branch
from
1450f7d to
90f1a59
Compare
cephalization
force-pushed
the
cephalization/react-compiler
branch
from
b45e114 to
cd74014
Compare
cephalization
force-pushed
the
cephalization/react-19
branch
2 times, most recently
from
d900124 to
7963bb3
Compare
cephalization
force-pushed
the
cephalization/react-compiler
branch
from
3640510 to
3f57016
Compare
mikeldking
force-pushed
the
cephalization/react-compiler
branch
2 times, most recently
from
78dc470 to
11a83ab
Compare
dosubot
bot
added
the
size:L
mikeldking
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mikeldking
force-pushed
the
cephalization/react-compiler
branch
from
778d9cb to
c878c90
Compare
dosubot
bot
added
size:M
| "test:e2e": "playwright test", | ||
| "test:e2e:ui": "playwright test --ui", | ||
| "dev": "pnpm run dev:server & pnpm run build:static && pnpm run build:relay && vite", | ||
| "dev": "pnpm run dev:server & pnpm run dev:ui", |
There was a problem hiding this comment.
Bug: Inconsistent React Compiler behavior across environments.
The build script doesn't source .env, so PHOENIX_ENABLE_REACT_COMPILER won't be available to vite.config.mts. This means the React Compiler will always be disabled during production builds, creating inconsistent behavior between development and production environments.
| "test:e2e": "playwright test", | ||
| "test:e2e:ui": "playwright test --ui", | ||
| "dev": "pnpm run dev:server & pnpm run build:static && pnpm run build:relay && vite", | ||
| "dev": "pnpm run dev:server & pnpm run dev:ui", |
There was a problem hiding this comment.
Bug: Inconsistent React Compiler in Dev Modes
The dev:offline and dev:embeddings scripts don't source .env before running vite, so PHOENIX_ENABLE_REACT_COMPILER won't be available. This creates inconsistent behavior where the React Compiler configuration works in dev mode but not in these alternative development modes.
yfrigui2
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.