-
Notifications
You must be signed in to change notification settings - Fork 645
feat: Add react compiler behind a config #9782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,6 +92,7 @@ | |
| "@types/relay-runtime": "^19.0.3", | ||
| "@types/three": "^0.180.0", | ||
| "@vitejs/plugin-react": "^4.7.0", | ||
| "babel-plugin-react-compiler": "1.0.0", | ||
| "babel-plugin-relay": "^20.1.1", | ||
| "chromatic": "^11.29.0", | ||
| "cpy-cli": "^5.0.0", | ||
|
|
@@ -126,10 +127,10 @@ | |
| "test:watch": "vitest", | ||
| "test:e2e": "playwright test", | ||
| "test:e2e:ui": "playwright test --ui", | ||
| "dev": "pnpm run dev:server & pnpm run build:static && pnpm run build:relay && vite", | ||
| "dev": "pnpm run dev:server & pnpm run dev:ui", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Inconsistent React Compiler in Dev ModesThe |
||
| "dev:offline": "pnpm run dev:server:offline & pnpm run build:static && pnpm run build:relay && vite", | ||
| "dev:embeddings": "pnpm run dev:server:embeddings & pnpm run build:static && pnpm run build:relay && vite", | ||
| "dev:ui": "pnpm run build:static && pnpm run build:relay && vite", | ||
| "dev:ui": "source ./.env && pnpm run build:static && pnpm run build:relay && vite", | ||
| "dev:server": "source ./.env && uv run --compile --with-requirements=../requirements/dev.txt phoenix --dev serve", | ||
| "dev:server:offline": "python -m phoenix.server.main --dev serve", | ||
| "dev:server:embeddings": "pnpm dev:server --with-fixture=fashion_mnist", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent React Compiler behavior across environments.
The
buildscript doesn't source.env, soPHOENIX_ENABLE_REACT_COMPILERwon't be available tovite.config.mts. This means the React Compiler will always be disabled during production builds, creating inconsistent behavior between development and production environments.